Add GetWorkflowIDFromPath helper function

- Created GetWorkflowIDFromPath() helper function in compiler_yaml_helpers.go
- Updated compiler_safe_outputs_consolidated.go to use the helper function
- Removed unused filepath and strings imports from compiler_safe_outputs_consolidated.go
- Added comprehensive test coverage for GetWorkflowIDFromPath()
- Renamed workflowFilename parameter to workflowID for clarity in buildJobLevelSafeOutputEnvVars()

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Author: Copilot

pkg/workflow/compiler_safe_outputs_consolidated.go

@@ -2,8 +2,6 @@ package workflow
 
 import (
 	"fmt"
-	"path/filepath"
-	"strings"
 
 	"github.com/githubnext/gh-aw/pkg/constants"
 	"github.com/githubnext/gh-aw/pkg/logger"
@@ -282,7 +280,7 @@ func (c *Compiler) buildConsolidatedSafeOutputsJob(data *WorkflowData, mainJobNa
 
 	// 9. Create Code Scanning Alert step
 	if data.SafeOutputs.CreateCodeScanningAlerts != nil {
-		workflowFilename := strings.TrimSuffix(filepath.Base(markdownPath), ".md")
+		workflowFilename := GetWorkflowIDFromPath(markdownPath)
 		stepConfig := c.buildCreateCodeScanningAlertStepConfig(data, mainJobName, threatDetectionEnabled, workflowFilename)
 		stepYAML := c.buildConsolidatedSafeOutputStep(data, stepConfig)
 		steps = append(steps, stepYAML...)
@@ -498,11 +496,11 @@ func (c *Compiler) buildConsolidatedSafeOutputsJob(data *WorkflowData, mainJobNa
 		needs = append(needs, constants.ActivationJobName)
 	}
 
-	// Extract workflow filename (without extension) for GH_AW_WORKFLOW_ID
-	workflowFilename := strings.TrimSuffix(filepath.Base(markdownPath), ".md")
+	// Extract workflow ID from markdown path for GH_AW_WORKFLOW_ID
+	workflowID := GetWorkflowIDFromPath(markdownPath)
 
 	// Build job-level environment variables that are common to all safe output steps
-	jobEnv := c.buildJobLevelSafeOutputEnvVars(data, workflowFilename)
+	jobEnv := c.buildJobLevelSafeOutputEnvVars(data, workflowID)
 
 	job := &Job{
 		Name:           "safe_outputs",
@@ -587,12 +585,12 @@ func (c *Compiler) buildConsolidatedSafeOutputStep(data *WorkflowData, config Sa
 
 // buildJobLevelSafeOutputEnvVars builds environment variables that should be set at the job level
 // for the consolidated safe_outputs job. These are variables that are common to all safe output steps.
-func (c *Compiler) buildJobLevelSafeOutputEnvVars(data *WorkflowData, workflowFilename string) map[string]string {
+func (c *Compiler) buildJobLevelSafeOutputEnvVars(data *WorkflowData, workflowID string) map[string]string {
 	envVars := make(map[string]string)
 
-	// Set GH_AW_WORKFLOW_ID to the workflow filename (without extension)
+	// Set GH_AW_WORKFLOW_ID to the workflow ID (filename without extension)
 	// This is used for branch naming in create_pull_request and other operations
-	envVars["GH_AW_WORKFLOW_ID"] = fmt.Sprintf("%q", workflowFilename)
+	envVars["GH_AW_WORKFLOW_ID"] = fmt.Sprintf("%q", workflowID)
 
 	// Add workflow metadata that's common to all steps
 	envVars["GH_AW_WORKFLOW_NAME"] = fmt.Sprintf("%q", data.Name)

pkg/workflow/compiler_yaml_helpers.go

@@ -2,6 +2,7 @@ package workflow
 
 import (
 	"fmt"
+	"path/filepath"
 	"strings"
 
 	"github.com/githubnext/gh-aw/pkg/constants"
@@ -10,6 +11,13 @@ import (
 
 var compilerYamlHelpersLog = logger.New("workflow:compiler_yaml_helpers")
 
+// GetWorkflowIDFromPath extracts the workflow ID from a markdown file path.
+// The workflow ID is the filename without the .md extension.
+// Example: "/path/to/ai-moderator.md" -> "ai-moderator"
+func GetWorkflowIDFromPath(markdownPath string) string {
+	return strings.TrimSuffix(filepath.Base(markdownPath), ".md")
+}
+
 // convertStepToYAML converts a step map to YAML format.
 // This is a method wrapper around the package-level ConvertStepToYAML function.
 func (c *Compiler) convertStepToYAML(stepMap map[string]any) (string, error) {

pkg/workflow/compiler_yaml_helpers_test.go

@@ -0,0 +1,41 @@
+package workflow
+
+import "testing"
+
+func TestGetWorkflowIDFromPath(t *testing.T) {
+	tests := []struct {
+		name     string
+		path     string
+		expected string
+	}{
+		{
+			name:     "simple filename",
+			path:     "ai-moderator.md",
+			expected: "ai-moderator",
+		},
+		{
+			name:     "full path",
+			path:     "/home/user/workflows/test-workflow.md",
+			expected: "test-workflow",
+		},
+		{
+			name:     "filename with multiple dots",
+			path:     "/path/to/workflow.test.md",
+			expected: "workflow.test",
+		},
+		{
+			name:     "relative path",
+			path:     ".github/workflows/daily-fact.md",
+			expected: "daily-fact",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := GetWorkflowIDFromPath(tt.path)
+			if result != tt.expected {
+				t.Errorf("GetWorkflowIDFromPath(%q) = %q, want %q", tt.path, result, tt.expected)
+			}
+		})
+	}
+}