Remove @ts-nocheck from 15 .cjs files and fix type errors (#7909)

Copilot · web-flow · commit fa6dd868f8c7 · 2025-12-27T09:43:09.000-08:00
diff --git a/actions/setup/js/add_copilot_reviewer.cjs b/actions/setup/js/add_copilot_reviewer.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 /**
@@ -52,7 +52,7 @@ Successfully added Copilot as a reviewer to PR #${prNumber}.
       )
       .write();
   } catch (error) {
-    const errorMessage = error?.message ?? String(error);
+    const errorMessage = error instanceof Error ? error.message : String(error);
     core.error(`Failed to add Copilot as reviewer: ${errorMessage}`);
     core.setFailed(`Failed to add Copilot as reviewer to PR #${prNumber}: ${errorMessage}`);
   }
diff --git a/actions/setup/js/add_reviewer.cjs b/actions/setup/js/add_reviewer.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 const { processSafeOutput, processItems } = require("./safe_output_processor.cjs");
@@ -50,8 +50,8 @@ async function main() {
     core.setFailed("Internal error: config, targetResult, or targetResult.number is undefined");
     return;
   }
-  const { allowed: allowedReviewers, maxCount } = config;
-  const prNumber = targetResult.number;
+  const { allowed: allowedReviewers, maxCount = 1 } = config;
+  const prNumber = /** @type {number} */ (targetResult.number);
 
   const requestedReviewers = reviewerItem.reviewers || [];
   core.info(`Requested reviewers: ${JSON.stringify(requestedReviewers)}`);
@@ -103,7 +103,8 @@ No reviewers were added (no valid reviewers found in agent output).
         });
         core.info(`Successfully added copilot as reviewer to PR #${prNumber}`);
       } catch (copilotError) {
-        core.warning(`Failed to add copilot as reviewer: ${copilotError?.message ?? String(copilotError)}`);
+        const copilotErrorMsg = copilotError instanceof Error ? copilotError.message : String(copilotError);
+        core.warning(`Failed to add copilot as reviewer: ${copilotErrorMsg}`);
         // Don't fail the whole step if copilot reviewer fails
       }
     }
@@ -123,7 +124,7 @@ ${reviewersListMarkdown}
       )
       .write();
   } catch (error) {
-    const errorMessage = error?.message ?? String(error);
+    const errorMessage = error instanceof Error ? error.message : String(error);
     core.error(`Failed to add reviewers: ${errorMessage}`);
     core.setFailed(`Failed to add reviewers: ${errorMessage}`);
   }
diff --git a/actions/setup/js/assign_agent_helpers.cjs b/actions/setup/js/assign_agent_helpers.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 /**
@@ -59,7 +59,8 @@ async function getAvailableAgentLogins(owner, repo) {
     const available = actors.filter(actor => actor?.login && knownValues.includes(actor.login)).map(actor => actor.login);
     return available.sort();
   } catch (e) {
-    core.debug(`Failed to list available agent logins: ${e?.message ?? String(e)}`);
+    const errorMessage = e instanceof Error ? e.message : String(e);
+    core.debug(`Failed to list available agent logins: ${errorMessage}`);
     return [];
   }
 }
@@ -117,7 +118,8 @@ async function findAgent(owner, repo, agentName) {
     }
     return null;
   } catch (error) {
-    core.error(`Failed to find ${agentName} agent: ${error?.message ?? String(error)}`);
+    const errorMessage = error instanceof Error ? error.message : String(error);
+    core.error(`Failed to find ${agentName} agent: ${errorMessage}`);
     return null;
   }
 }
@@ -161,7 +163,8 @@ async function getIssueDetails(owner, repo, issueNumber) {
       currentAssignees,
     };
   } catch (error) {
-    core.error(`Failed to get issue details: ${error?.message ?? String(error)}`);
+    const errorMessage = error instanceof Error ? error.message : String(error);
+    core.error(`Failed to get issue details: ${errorMessage}`);
     return null;
   }
 }
@@ -204,21 +207,22 @@ async function assignAgentToIssue(issueId, agentId, currentAssignees, agentName)
     core.error("Unexpected response from GitHub API");
     return false;
   } catch (error) {
-    const errorMessage = error?.message ?? String(error);
+    const errorMessage = error instanceof Error ? error.message : String(error);
 
     // Debug: surface the raw GraphQL error structure for troubleshooting fine-grained permission issues
     try {
       core.debug(`Raw GraphQL error message: ${errorMessage}`);
       if (error && typeof error === "object") {
         // Common GraphQL error shapes: error.errors (array), error.data, error.response
+        const err = /** @type {any} */ (error);
         const details = {
-          ...(error.errors && { errors: error.errors }),
-          ...(error.response && { response: error.response }),
-          ...(error.data && { data: error.data }),
+          ...(err.errors && { errors: err.errors }),
+          ...(err.response && { response: err.response }),
+          ...(err.data && { data: err.data }),
         };
         // If GitHub returns an array of errors with 'type'/'message'
-        if (Array.isArray(error.errors)) {
-          details.compactMessages = error.errors.map(e => e.message).filter(Boolean);
+        if (Array.isArray(err.errors)) {
+          details.compactMessages = err.errors.map(e => e.message).filter(Boolean);
         }
         const serialized = JSON.stringify(details, null, 2);
         if (serialized !== "{}") {
@@ -233,7 +237,8 @@ async function assignAgentToIssue(issueId, agentId, currentAssignees, agentName)
       }
     } catch (loggingErr) {
       // Never fail assignment because of debug logging
-      core.debug(`Failed to serialize GraphQL error details: ${loggingErr?.message ?? String(loggingErr)}`);
+      const loggingErrMsg = loggingErr instanceof Error ? loggingErr.message : String(loggingErr);
+      core.debug(`Failed to serialize GraphQL error details: ${loggingErrMsg}`);
     }
 
     // Check for permission-related errors
@@ -263,7 +268,8 @@ async function assignAgentToIssue(issueId, agentId, currentAssignees, agentName)
         }
         core.warning("Fallback mutation returned unexpected response; proceeding with permission guidance.");
       } catch (fallbackError) {
-        core.error(`Fallback addAssigneesToAssignable failed: ${fallbackError?.message ?? String(fallbackError)}`);
+        const fallbackErrMsg = fallbackError instanceof Error ? fallbackError.message : String(fallbackError);
+        core.error(`Fallback addAssigneesToAssignable failed: ${fallbackErrMsg}`);
       }
       logPermissionError(agentName);
     } else {
@@ -392,7 +398,8 @@ async function assignAgentToIssueByName(owner, repo, issueNumber, agentName) {
     core.info(`Successfully assigned ${agentName} coding agent to issue #${issueNumber}`);
     return { success: true };
   } catch (error) {
-    return { success: false, error: error?.message ?? String(error) };
+    const errorMessage = error instanceof Error ? error.message : String(error);
+    return { success: false, error: errorMessage };
   }
 }
 
diff --git a/actions/setup/js/assign_copilot_to_created_issues.cjs b/actions/setup/js/assign_copilot_to_created_issues.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 const { AGENT_LOGIN_NAMES, findAgent, getIssueDetails, assignAgentToIssue, generatePermissionErrorSummary } = require("./assign_agent_helpers.cjs");
@@ -109,7 +109,7 @@ async function main() {
         success: true,
       });
     } catch (error) {
-      const errorMessage = error?.message ?? String(error);
+      const errorMessage = error instanceof Error ? error.message : String(error);
       core.error(`Failed to assign ${agentName} to issue #${issueNumber} in ${repoSlug}: ${errorMessage}`);
       results.push({
         repo: repoSlug,
diff --git a/actions/setup/js/assign_issue.cjs b/actions/setup/js/assign_issue.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 const { getAgentName, getIssueDetails, findAgent, assignAgentToIssue } = require("./assign_agent_helpers.cjs");
@@ -95,7 +95,7 @@ Successfully assigned issue #${trimmedIssueNumber} to \`${trimmedAssignee}\`.
       )
       .write();
   } catch (error) {
-    const errorMessage = error?.message ?? String(error);
+    const errorMessage = error instanceof Error ? error.message : String(error);
     core.error(`Failed to assign issue: ${errorMessage}`);
     core.setFailed(`Failed to assign issue #${trimmedIssueNumber} to ${trimmedAssignee}: ${errorMessage}`);
   }
diff --git a/actions/setup/js/assign_milestone.cjs b/actions/setup/js/assign_milestone.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 const { processSafeOutput } = require("./safe_output_processor.cjs");
@@ -41,7 +41,7 @@ async function main() {
     core.setFailed("Internal error: config or milestoneItems is undefined");
     return;
   }
-  const { allowed: allowedMilestones, maxCount } = config;
+  const { allowed: allowedMilestones, maxCount = 1 } = config;
 
   // Limit items to max count
   const itemsToProcess = milestoneItems.slice(0, maxCount);
@@ -62,7 +62,7 @@ async function main() {
       allMilestones = milestonesResponse.data;
       core.info(`Fetched ${allMilestones.length} milestones from repository`);
     } catch (error) {
-      const errorMessage = error?.message ?? String(error);
+      const errorMessage = error instanceof Error ? error.message : String(error);
       core.error(`Failed to fetch milestones: ${errorMessage}`);
       core.setFailed(`Failed to fetch milestones for validation: ${errorMessage}`);
       return;
@@ -86,7 +86,7 @@ async function main() {
     }
 
     // Validate against allowed list if configured
-    if (allowedMilestones?.length > 0) {
+    if (allowedMilestones && allowedMilestones.length > 0) {
       const milestone = allMilestones.find(m => m.number === milestoneNumber);
 
       if (!milestone) {
@@ -119,7 +119,7 @@ async function main() {
         success: true,
       });
     } catch (error) {
-      const errorMessage = error?.message ?? String(error);
+      const errorMessage = error instanceof Error ? error.message : String(error);
       core.error(`Failed to assign milestone #${milestoneNumber} to issue #${issueNumber}: ${errorMessage}`);
       results.push({
         issue_number: issueNumber,
diff --git a/actions/setup/js/assign_to_agent.cjs b/actions/setup/js/assign_to_agent.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 const { loadAgentOutput } = require("./load_agent_output.cjs");
@@ -148,7 +148,7 @@ async function main() {
         success: true,
       });
     } catch (error) {
-      let errorMessage = error?.message ?? String(error);
+      let errorMessage = error instanceof Error ? error.message : String(error);
       if (errorMessage.includes("coding agent is not available for this repository")) {
         // Enrich with available agent logins to aid troubleshooting - uses built-in github object
         try {
diff --git a/actions/setup/js/assign_to_user.cjs b/actions/setup/js/assign_to_user.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 const { processSafeOutput, processItems } = require("./safe_output_processor.cjs");
@@ -49,7 +49,7 @@ async function main() {
     core.setFailed("Internal error: config, targetResult, or targetResult.number is undefined");
     return;
   }
-  const { allowed: allowedAssignees, maxCount } = config;
+  const { allowed: allowedAssignees, maxCount = 1 } = config;
   const issueNumber = targetResult.number;
 
   // Support both singular "assignee" and plural "assignees" for flexibility
diff --git a/actions/setup/js/check_workflow_timestamp_api.cjs b/actions/setup/js/check_workflow_timestamp_api.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 /**
@@ -40,15 +40,20 @@ async function main() {
 
       if (response.data && response.data.length > 0) {
         const commit = response.data[0];
+        const committerDate = commit.commit.committer?.date;
+        if (!committerDate) {
+          return null;
+        }
         return {
           sha: commit.sha,
-          date: commit.commit.committer.date,
+          date: committerDate,
           message: commit.commit.message,
         };
       }
       return null;
     } catch (error) {
-      core.info(`Could not fetch commit for ${path}: ${error.message}`);
+      const errorMessage = error instanceof Error ? error.message : String(error);
+      core.info(`Could not fetch commit for ${path}: ${errorMessage}`);
       return null;
     }
   }
diff --git a/actions/setup/js/interpolate_prompt.cjs b/actions/setup/js/interpolate_prompt.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 // interpolate_prompt.cjs
@@ -89,6 +89,7 @@ async function main() {
     }
 
     // Step 2: Interpolate variables
+    /** @type {Record<string, string>} */
     const variables = {};
     for (const [key, value] of Object.entries(process.env)) {
       if (key.startsWith("GH_AW_EXPR_")) {
diff --git a/actions/setup/js/link_sub_issue.cjs b/actions/setup/js/link_sub_issue.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 const { loadAgentOutput } = require("./load_agent_output.cjs");
@@ -133,13 +133,24 @@ async function main() {
       continue;
     }
 
-    const parentIssueNumber = parentResolved.resolved.number;
-    const subIssueNumber = subResolved.resolved.number;
+    const parentIssueNumber = parentResolved.resolved?.number;
+    const subIssueNumber = subResolved.resolved?.number;
 
-    if (parentResolved.wasTemporaryId) {
+    if (!parentIssueNumber || !subIssueNumber) {
+      core.error("Internal error: Issue numbers are undefined after successful resolution");
+      results.push({
+        parent_issue_number: item.parent_issue_number,
+        sub_issue_number: item.sub_issue_number,
+        success: false,
+        error: "Issue numbers undefined",
+      });
+      continue;
+    }
+
+    if (parentResolved.wasTemporaryId && parentResolved.resolved) {
       core.info(`Resolved parent temporary ID '${item.parent_issue_number}' to ${parentResolved.resolved.repo}#${parentIssueNumber}`);
     }
-    if (subResolved.wasTemporaryId) {
+    if (subResolved.wasTemporaryId && subResolved.resolved) {
       core.info(`Resolved sub-issue temporary ID '${item.sub_issue_number}' to ${subResolved.resolved.repo}#${subIssueNumber}`);
     }
 
diff --git a/actions/setup/js/mcp_http_transport.cjs b/actions/setup/js/mcp_http_transport.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 /**
@@ -33,11 +33,14 @@ class MCPServer {
    * @param {string} serverInfo.version - Server version
    * @param {Object} [options] - Server options
    * @param {Object} [options.capabilities] - Server capabilities
+   * @param {string} [options.logDir] - Log directory path
    */
   constructor(serverInfo, options = {}) {
-    this._coreServer = createServer(serverInfo, options);
+    // Extract logDir for createServer, keep capabilities for this class
+    const { capabilities, logDir } = options;
+    this._coreServer = createServer(serverInfo, { logDir });
     this.serverInfo = serverInfo;
-    this.capabilities = options.capabilities || { tools: {} };
+    this.capabilities = capabilities || { tools: {} };
     this.tools = new Map();
     this.transport = null;
     this.initialized = false;
@@ -254,10 +257,10 @@ class MCPHTTPTransport {
       }
 
       // Process the request through the MCP server
-      const response = await this.server.handleRequest(body);
+      const response = await this.server?.handleRequest(body);
 
       // Handle notifications (null response means no reply needed)
-      if (response === null) {
+      if (response === null || response === undefined) {
         res.writeHead(204); // No Content
         res.end();
         return;
diff --git a/actions/setup/js/notify_comment_error.cjs b/actions/setup/js/notify_comment_error.cjs
@@ -1,4 +1,4 @@
-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring
+// @ts-check
 /// <reference types="@actions/github-script" />
 
 // This script updates an existing comment created by the activation job
@@ -65,8 +65,8 @@ async function main() {
   // Load agent output to check for noop messages
   let noopMessages = [];
   const agentOutputResult = loadAgentOutput();
-  if (agentOutputResult.success && agentOutputResult.data) {
-    const noopItems = agentOutputResult.data.items.filter(item => item.type === "noop");
+  if (agentOutputResult.success) {
+    const noopItems = agentOutputResult.items.filter(item => item.type === "noop");
     if (noopItems.length > 0) {
       core.info(`Found ${noopItems.length} noop message(s)`);
       noopMessages = noopItems.map(item => item.message);
diff --git a/actions/setup/js/package-lock.json b/actions/setup/js/package-lock.json
diff --git a/actions/setup/js/parse_copilot_log.cjs b/actions/setup/js/parse_copilot_log.cjs
diff --git a/actions/setup/js/safe_inputs_bootstrap.cjs b/actions/setup/js/safe_inputs_bootstrap.cjs

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// @ts-nocheck - Type checking disabled due to complex type errors requiring refactoring`
	`1`	`+// @ts-check`
`2`	`2`	`/// <reference types="@actions/github-script" />`
`3`	`3`
`4`	`4`	`/**`
`@@ -52,7 +52,7 @@ Successfully added Copilot as a reviewer to PR #${prNumber}.`
`52`	`52`	`)`
`53`	`53`	`.write();`
`54`	`54`	`} catch (error) {`
`55`		`- const errorMessage = error?.message ?? String(error);`
	`55`	`+ const errorMessage = error instanceof Error ? error.message : String(error);`
`56`	`56`	core.error(`Failed to add Copilot as reviewer: ${errorMessage}`);
`57`	`57`	core.setFailed(`Failed to add Copilot as reviewer to PR #${prNumber}: ${errorMessage}`);
`58`	`58`	`}`