[eslint-refiner] ESLint Refiner — Daily Report 2026-07-12

[github-actions[bot]]

Overview

The eslint-factory rule set grew from 12 to 15 rules since the last run (2026-07-08). Three new rules landed as a batch: no-throw-plain-object, no-github-request-interpolated-route (already documented in the README), and require-return-after-core-setfailed (the 15th, undocumented). This run reviewed the two undocumented newcomers and filed 2 refinement issues (1 grounded HIGH, 1 latent MED).

Key metrics

Metric	Value
Rules registered (index.ts)	15 (was 12)
Rules reviewed this run	2 (require-return-after-core-setfailed, no-throw-plain-object)
Issues filed	2 (dedup-checked, no duplicates)
Live violations found	require-return: 0 (corpus disciplined) · no-throw-plain-object: 22 grounded sites
README doc coverage	13 / 15 (2 new rules undocumented)

Issues filed

1. no-throw-plain-object — add an Object.assign(new Error(...)) suggestion (HIGH, grounded). The rule flags throw { ... } but ships no suggestion, even though its message prescribes the exact rewrite. It fires on 22 live production sites — JSON-RPC error objects ({ code, message, data }) in mcp_server_core.cjs (×10) and safe_outputs_handlers.cjs (×12) — so automating the rewrite would make the rule actionable across a real, existing population. Recommended as an opt-in suggestion (not autofix) because some transport code may JSON.stringify the caught value.
2. require-return-after-core-setfailed — aliased/destructured core.setFailed escapes detection (MED, latent). Detection is literal-only (core.setFailed), so const { setFailed } = core; setFailed(msg) and const c = core; c.setFailed(msg) are false negatives. Ungrounded today (the corpus is disciplined) but mirrors alias-blindspot fixes already made for sibling rules (fix(eslint): detect dropped await on local core.summary aliases #43404, eslint-factory: require-error-cause-in-rethrow's expressionReferencesCatchVar skips LogicalExpression/ConditionalExpression (idi [Content truncated due to length] #43948).

Assessment of the newest rule

require-return-after-core-setfailed is robust and well-tested

The control-flow analysis handles same-block sequencing, cross-block continuation through if/else/else if, loop back-edges (while/do/for/for-in/for-of), and switch fall-through, and correctly stops at function boundaries. Traced true-negatives on the live corpus — all correct:

• check_permissions.cjs:45 — setFailed last in a terminal if-block
• parse_threat_detection_results.cjs:477 — setFailed terminal in an else-block (setDetectionFailure)
• add_workflow_run_comment.cjs:165 — setFailed last in reportCommentError
• redact_secrets.cjs:281 — setFailed last in a catch

Every production core.setFailed(...) is followed by return or is block/function-terminal → zero live violations. The rule mainly guards against regressions.

Notes / not filed

• Weak-diagnostic (discussion-only): inside array-iteration callbacks — arr.forEach(x => { if (bad) { core.setFailed(); } work(x); }) — the rule flags and suggests inserting return;, but return in a forEach callback only skips the current element; it does not stop the action. This is analogous to the rule's already-documented break/continue limitation and probably warrants a docs note rather than a code change.
• By design (not a defect): flagging a loop body that ends in core.setFailed() — the rule intentionally treats loop re-iteration in a failed state as a violation (asserted by its tests).
• Doc debt: README documents 13 / 15 rules; no-throw-plain-object and require-return-after-core-setfailed are undocumented. Recommend a follow-up docs pass.

Next actions

• Next run: re-diff index.ts for a possible 16th rule; otherwise give no-github-request-interpolated-route its first tracked review (grep interpolated .request( sites to ground).
• If the no-throw-plain-object suggestion lands, re-verify the rewrites against the MCP corpus for behavior preservation.
• Consider a single documentation issue to close the README 13/15 gap.

References: §29182253758

Generated by 🤖 ESLint Refiner · 354.5 AIC · ⌖ 12.7 AIC · ⊞ 4.6K · ◷

• expires on Jul 12, 2026, 10:27 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by ESLint Refiner.

A newer discussion is available at Discussion #45208.