Fix changeset.js to prompt for confirmation before modifying files#1549
Merged
Fix changeset.js to prompt for confirmation before modifying files#1549
Conversation
Move the confirmation prompt to happen before updateChangelog() and deleteChangesetFiles() are called. Previously, files were modified before asking for user confirmation, which meant canceling would leave the repository in a modified state. Now, if the user cancels, no files are changed. Changes: - Moved promptConfirmation() call before file modifications - Updated confirmation message to reflect all operations - Updated cancellation message to accurately state "No changes have been made" Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Ensure confirmation occurs before changing files in changeset.js
Fix changeset.js to prompt for confirmation before modifying files
Oct 11, 2025
pelikhan
approved these changes
Oct 11, 2025
Contributor
|
Agentic Changeset Generator triggered by this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
changeset.jsrelease command was asking for user confirmation after already modifying files. This created a poor user experience where canceling the release left the repository in a modified state requiring manual cleanup.The problematic flow was:
Solution
Moved the confirmation prompt to happen before any file modifications. Now users can safely cancel without leaving the repository in a modified state.
The corrected flow is:
Changes
promptConfirmation()call to execute beforeupdateChangelog()anddeleteChangesetFiles()Testing
Verified the order of operations using automated testing to ensure confirmation now happens at line 41 of the
runRelease()function, before file modifications at lines 49 and 52.Impact
This is a minimal change (9 insertions, 10 deletions) that significantly improves the user experience by ensuring confirmation happens before any destructive operations. No breaking changes to functionality.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.