fix: non-fatal create_issue + verbatim image URL enforcement for agentic-optimization-kit#28021
Closed
Copilot wants to merge 2 commits into
Closed
fix: non-fatal create_issue + verbatim image URL enforcement for agentic-optimization-kit#28021Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…tim image URL guidance
- trending-charts-simple.md: show upload_asset response format; require copying
the `url` field verbatim — never reconstruct from sha or file path
- agentic-optimization-kit.md Phase 4: reinforce using only returned URLs;
add `non-fatal: true` to create-issue so rate-limit 403 doesn't fail the job
- create_issue.go: add NonFatal bool field to CreateIssuesConfig
- compiler_safe_outputs_handlers.go: wire non_fatal into create_issue handler JSON
- main_workflow_schema.json: add non-fatal property to create-issue schema
- create_issue.cjs: return {nonFatal: true} on catch when non_fatal configured
- safe_output_handler_manager.cjs: exclude nonFatal results from failureCount,
log as warning instead of error, add nonFatalCount to summary"
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/5898d83f-2723-4a71-a5ba-cf522948158f
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…rn in create_issue.cjs Agent-Logs-Url: https://github.com/github/gh-aw/sessions/5898d83f-2723-4a71-a5ba-cf522948158f Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mnkiefer
April 23, 2026 10:33
View session
Collaborator
|
github-actions
Bot
deleted the
copilot/investigate-missing-images-issue-creation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run 24824838890 surfaced two bugs: one chart image in discussion #28014 had a broken URL (agent reconstructed the URL from the SHA instead of copying the returned
urlfield, introducing a single hex digit error), and the escalationcreate_issuefailed with a rate-limit 403 — causing the entiresafe_outputsjob to fail even though the main discussion was successfully created.Image URL enforcement
shared/trending-charts-simple.md: Shows the exactupload_assetresponse shape and requires copying theurlfield verbatim. Explicit warning against reconstructing fromshaor file path.agentic-optimization-kit.mdPhase 4: Same instruction inline — capture the returnedurlimmediately after each upload before building the report body.non-fatalcreate_issue modeAdds a
non-fatal: trueoption tocreate-issuesafe-outputs so transient API failures (rate limits, 5xx) degrade to a warning rather than failing the job.CreateIssuesConfig(create_issue.go): newNonFatal boolfield (non-fatal:in YAML).compiler_safe_outputs_handlers.go): wiresnon_fatalinto the serializedGH_AW_SAFE_OUTPUTS_HANDLER_CONFIGJSON.main_workflow_schema.json): addsnon-fatalproperty tocreate-issue(schema hasadditionalProperties: false).create_issue.cjs: returns{ success: false, nonFatal: true }and logscore.warninginstead ofcore.errorwhenconfig.non_fatalis set.safe_output_handler_manager.cjs: extractsisCriticalFailure()predicate; excludesnonFatalresults fromfailureCountandcore.setFailed(). Logs anonFatalCountwarning line in the processing summary.agentic-optimization-kit.md: addsnon-fatal: trueto itscreate-issueconfig — escalation issues are best-effort and shouldn't block the run.