Update AWF to v0.5.0 and migrate to new container/log naming conventions#4877
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
|
✅ Agentic Changeset Generator completed successfully. |
|
@copilot make sure to update the workflow run trace parsing (must be backward compatible) for the new naming convention. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Added backward compatibility for workflow run trace parsing in commit 867b886. The log discovery pattern now checks for both the new AGENT_LOGS_DIR="$(find /tmp -maxdepth 1 -type d \( -name 'awf-agent-logs-*' -o -name 'copilot-logs-*' \) -print0 2>/dev/null | xargs -0 ls -td 2>/dev/null | head -1)"Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
✅ Agentic Changeset Generator completed successfully. |
|
@copilot can you figure out why this test is failing, update your pr description with your findings, and then resolve the issue? https://github.com/githubnext/gh-aw/actions/runs/19717558809/job/56493386225?pr=4877 |
The test failures are pre-existing issues on Failing tests:
Evidence:
This PR's changes (AWF version bump, log directory naming, backward-compatible log discovery) are unrelated to these test failures. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
.copilot/logs/to.agent/logs/copilot-logs-*toawf-agent-logs-*copilot-logs-*patternCOPILOT_LOGS_DIRtoAGENT_LOGS_DIRcopilot-logstoagent-logsTest Failure Investigation
The CI failure in workflow run 19717558809 was investigated. The failing tests are:
TestTopLevelGitHubTokenPrecedence/safe-outputs_github-token_overrides_top-levelTestNeutralToolsIntegrationFinding: These are pre-existing test failures on
main, not caused by this PR's changes.Evidence:
The AWF v0.5.0 migration changes (version bump, log directory naming, backward-compatible log discovery) are unrelated to these test failures.
Original prompt
you are tasked to update the awf version to v0.5.0 and migrate to the following breaking changes:
The new change renames internal "copilot" references to "agent" to better reflect support for multiple AI coding agents (GitHub Copilot CLI, Claude Code). This is a breaking change.
Breaking Changes Summary
awf-copilotawf-agentghcr.io/.../copilot:*ghcr.io/.../agent:*/tmp/copilot-logs-*/tmp/awf-agent-logs-*containers/copilot/containers/agent/copilotCommandagentCommandrunCopilotCommand()runAgentCommand()copilotIp,copilotVolumes,copilotServiceagentIp,agentVolumes,agentServiceUnchanged: External references to GitHub Copilot CLI (
@github/copilotnpm package,~/.copilot/paths) remain unchanged.Docker Image Backward Compatibility
Existing published images are NOT deleted. The rename only affects new releases.
ghcr.io/.../copilot:v0.3.0ghcr.io/.../copilot:latestghcr.io/.../agent:v0.4.0+ghcr.io/.../agent:latestSafe migration path:
v0.3.0continue working with oldcopilotimagesagentimagesCode Quality Analysis
Strengths
Potential Issues
Migration Guide for Consumer Repo (gh-aw)
Critical Files Requiring Updates
1. Log Directory Constants
File:
pkg/workflow/copilot_engine.go2. Log Discovery Pattern
File:
pkg/workflow/copilot_engine.goAlso update the subsequent references from
$COPILOT_LOGS_DIRto$AGENT_LOGS_DIRin lines 262-267.3. Test File Assertions
File:
pkg/workflow/copilot_engine_test.goUpdate all test assertions that check for
.copilot/logs/paths:mkdir -p /tmp/gh-aw/.copilot/logs/→.agent/logs/GH_AW_AGENT_OUTPUTenv var path--log-dirparameterFile:
pkg/workflow/agentic_output_test.go.copilot/logs/references to.agent/logs/4. CI/CD Workflow
File:
.github/workflows/test-copilot-github-integration.yml5. Domain Configuration (Optional but Recommended)
File:
pkg/workflow/domains.goConsider renaming for consistency:
CopilotDefaultDomains→AgentDefaultDomainsGetCopilotAllowedDomains()→GetAgentAllowedDomains()Migration Checklist
For gh-aw Consumers
logsFolderconstant inpkg/workflow/copilot_engine.gocopilot-logs-*toawf-agent-logs-*COPILOT_LOGS_DIRtoAGENT_LOGS_DIRcopilot_engine_test.goagentic_output_test.goDefaultFirewallVersioninpkg/constants/constants.goto the new release version💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.