Skip to content

Fix custom safe output messages not passed to activation and conclusion jobs#4903

Merged
pelikhan merged 7 commits into
mainfrom
copilot/check-custom-output-messages
Nov 27, 2025
Merged

Fix custom safe output messages not passed to activation and conclusion jobs#4903
pelikhan merged 7 commits into
mainfrom
copilot/check-custom-output-messages

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 27, 2025 •
edited
Loading

  • Understand the issue: Custom safe output messages were not being passed to the conclusion job
  • Update notify_comment.go to pass GH_AW_SAFE_OUTPUT_MESSAGES environment variable to the conclusion job
  • Update notify_comment_error.cjs to use getRunSuccessMessage/getRunFailureMessage from messages.cjs
  • Update add_reaction_and_edit_comment.cjs to use getRunStartedMessage from messages.cjs for activation comments
  • Update compiler_jobs.go to pass messages env var to activation job when configured
  • Apply bundling to add_reaction_and_edit_comment.cjs - Register the script in ScriptRegistry so messages.cjs is properly bundled/inlined during compilation
  • Remove caching from messages.cjs - Simplified the module by removing unnecessary caching logic
  • Add tests to verify messages are passed correctly to both activation and conclusion jobs
  • Recompile workflows to verify the fix
  • Run tests to verify the fix
Original prompt

The changes generator agentic workflow has custom safe output messages (defined in front matter) that should modify auto generated footers and messages are generated.

Check compiled code to make sure the messages are passed to the JavaScript .

Comment with wrong text: #4897 (comment)
Workflow run : https://github.com/githubnext/gh-aw/actions/runs/19721762086/job/56505586371

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented Nov 27, 2025

@copilot they also need to be passed to the activation job

Copilot AI and others added 2 commits November 27, 2025 01:26
@pelikhan
Fix: Pass custom safe output messages to conclusion job for run statu…
6d66413 
…s comments

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Improve test assertions to check for specific pirate-themed messages
0db2029 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Check custom safe output messages in workflow Fix custom safe output messages not passed to conclusion job Nov 27, 2025
Copilot AI requested a review from pelikhan November 27, 2025 01:40
@pelikhan
Pass custom safe output messages to activation job for run-started co…
98f76fe 
…mments

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Nov 27, 2025 •
edited
Loading

@copilot they also need to be passed to the activation job

Done in 98f76fe. Updated add_reaction_and_edit_comment.cjs to use getRunStartedMessage from messages.cjs and pass GH_AW_SAFE_OUTPUT_MESSAGES env var to the activation job's reaction step when custom messages are configured.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Fix custom safe output messages not passed to conclusion job Fix custom safe output messages not passed to activation and conclusion jobs Nov 27, 2025
@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented Nov 27, 2025

@copilot apply bundled to messages.cja

@pelikhan
Apply bundling to add_reaction_and_edit_comment.cjs for messages.cjs …
146c229 
…inlining

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Nov 27, 2025 •
edited
Loading

@copilot apply bundled to messages.cja

Done in 146c229. Registered add_reaction_and_edit_comment.cjs in ScriptRegistry so messages.cjs is properly bundled/inlined during compilation.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented Nov 27, 2025

@copilot do not bother to cache messages in messages.cjs . Keep this messages.cjs extremely simple. Performance is not a goal.

@pelikhan
Remove caching from messages.cjs for simplicity
055f3d7 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Nov 27, 2025

@copilot do not bother to cache messages in messages.cjs . Keep this messages.cjs extremely simple. Performance is not a goal.

Done in 055f3d7. Removed caching logic and clearMessagesCache function from messages.cjs.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2025

⚓ Avast! Smoke Codex be settin' sail on this pull request! 🏴‍☠️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2025 •
edited
Loading

💀 Blimey! Smoke Copilot failed and walked the plank! No treasure today, matey! ☠️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2025

⚓ Avast! Smoke Claude be settin' sail on this pull request! 🏴‍☠️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2025 •
edited
Loading

💀 Blimey! Smoke Copilot No Firewall failed and walked the plank! No treasure today, matey! ☠️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2025 •
edited by agentic-workflows-dev Bot
Loading

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2025

Smoke Test Results

PRs: #4897 "Add reusable formatToolCallAsDetails helper", #4902 "Add debugging logs to playwright MCP"

✅ GitHub MCP (2 merged PRs fetched)
✅ File writing (/tmp/smoke-test-claude-sonnet-4-5.txt created)
✅ Bash tool (file verified)
✅ Playwright MCP (GitHub page loaded, title confirmed)

Status: PASS

AI generated by Smoke Claude for #4903

@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented Nov 27, 2025

Generate different store style messages for each smoke agentic workflow:

  • robotic, descriptive
  • pirates (already used)
  • graphic novel dialog style
  • enigmatic
  • journalistic

Each should be unique.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2025

Add reusable formatToolCallAsDetails helper for consistent HTML details rendering in log parsers
Add debugging logs to playwright MCP in smoke-copilot workflow
GitHub MCP review ✅
File write ✅
Playwright title check ✅
Overall: PASS

AI generated by Smoke Codex for #4903

@pelikhan pelikhan marked this pull request as ready for review November 27, 2025 03:08
@pelikhan pelikhan merged commit 946efbe into main Nov 27, 2025
17 checks passed
@pelikhan pelikhan deleted the copilot/check-custom-output-messages branch November 27, 2025 03:08
github-actions Bot added a commit that referenced this pull request Nov 27, 2025
@github-actions @claude
docs: Add safe-outputs.messages customization documentation
fce867c 
Add documentation for the safe-outputs.messages feature that allows
users to customize notification messages and footers.

- Document all available message templates (footer, run-started, etc.)
- List all placeholder variables with descriptions
- Include example configuration
- Note import and override behavior for shared workflows

Related PRs: #4903, #4904, #4906

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot mentioned this pull request Nov 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pelikhan pelikhan Awaiting requested review from pelikhan

Assignees

@pelikhan pelikhan

Copilot code review Copilot

Labels

smoke smoke-claude smoke-codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pelikhan