Fix log parser empty array handling causing false success#5981
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Fix parseLogEntries to return null for empty JSON arrays - Fix parseCopilotLog to check for empty arrays - Add test case for empty JSON array - Recompile all affected workflows Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
|
📰 BREAKING: Smoke Copilot Playwright is now investigating this pull request. Sources say the story is developing... |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 https://github.com/githubnext/gh-aw/tree/copilot/fix-agent-log-summary-issue |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Smoke Test Results - Run 20076258542PRs: #5977 ([WIP] Fix issues in existing test cases), #5983 ([WIP] Fix issues in test cases)
Status: PASS
|
Copilot Engine Smoke Test Results (Run 20076258445)Last 2 Merged PRs:
Test Results:
Overall Status: PASS
|
Smoke Test Results (Run 20076258435)✅ Playwright MCP: Successfully navigated to GitHub and verified title contains "GitHub" Overall Status: FAIL The safeinputs-gh tool encountered a network configuration issue (HTTP response to HTTPS client).
|
|
Recent merged PRs: Add continue-on-error to firewall logs upload step; [WIP] Fix issues in existing test cases
|
Log parsing silently succeeded with empty arrays instead of returning null, causing the error check
if (!logEntries)to pass incorrectly (empty arrays are truthy in JavaScript).Changes
log_parser_shared.cjs: Check array length before returning fromparseLogEntries()parse_copilot_log.cjs: Add empty array check to error conditionparse_copilot_log.test.cjs: Add test case for empty JSON array[].github/workflows/*.lock.yml: Recompiled 93 workflows with fixesWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/githubnext/gh-aw/actions/runs/20075011165/jobs/usr/bin/curl curl -s -H Authorization: token REDACTED(http block)https://api.github.com/user/usr/bin/gh gh api user --jq .login super-linter.git GO111MODULE ache/go/1.25.0/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/x64/pkg/tool/linux_amd64/compile -uns�� ef/tags/v0.20.10 /tmp/go-build2180867831/b049/vet.cfg 1/x64/bin/npm GOSUMDB bnext/gh-aw/pkg/-1 /usr/bin/sh 1/x64/bin/npm(http block)/usr/bin/gh gh api user --jq .login by.git /tmp/go-build2180867831/b010/vet.cfg 0867831/b364/styles.test GOSUMDB GOWORK de_modules/.bin/user 0867831/b364/sty--jq e=/t�� tags/93cb6efe18208431cddfb8368fd83d5badbf9bfd /tmp/go-build2180867831/b101/vet.cfg(http block)/usr/bin/gh gh api user --jq .login 61/update_issue.test-logs/run-12346 v0.0.0-test 07c4ca4694e7b3bc273c547a6e49a8b87a7/log.json version grep 64/pkg/tool/linu"mcp-server-playwright" --help /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linufeature-branch -uns�� -unreachable=false /tmp/go-build2180867831/b244/vet.cfg e/git _.a parsing to handl-namespace 64/pkg/tool/linumoby e/git(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Changeset