Use official Copilot CLI installer script with security improvements#6691
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Replace installer script with direct binary download - Add SHA256 checksum verification before installation - Implement graceful fallback for older releases without checksums - Update tests to validate new implementation - Test with dev.md workflow as proof of concept Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Fix test expectations for new checksum verification pattern - Add comprehensive documentation about the implementation - Document 74 affected workflows Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
@copilot use the script at https://github.com/github/copilot-cli/blob/main/install.sh |
Per @pelikhan feedback, switch to using the official installer script from https://github.com/github/copilot-cli/blob/main/install.sh instead of custom checksum verification implementation. Security improvements: - Download script from official repository (not gh.io redirect) - Save to temporary file before execution (not piped to bash) - Clean up temporary file after installation Updated tests to verify new implementation. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated implementation to use the official install.sh script from the Copilot CLI repository. The script is now downloaded from Security improvements maintained:
Commit: 5b120c4 |
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
@copilot can do make this a single command? export VERSION=0.0.369 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Per @pelikhan feedback, combine the export VERSION and sudo bash commands into a single line using && operator for cleaner output. Changed from: export VERSION=0.0.369 sudo bash /tmp/copilot-install.sh To: export VERSION=0.0.369 && sudo bash /tmp/copilot-install.sh Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Smoke Test Results (Run 20291926982)Last 2 Merged PRs:
Test Results:
Status: PASS ✅
|
Smoke Test Results - Claude EngineLast 2 merged PRs:
Test Results: Status: PARTIAL PASS (5/6 tests passed)
|
|
Merged PRs: Add SessionTimeout to MCP HTTP server to prevent resource leaks | Extract MCP timeout constants for maintainability
|
Plan: Add SHA256 Checksum Verification for Copilot CLI Installer Script
Status: ✅ Implementation Complete - Using Official Install Script
Summary
Updated implementation to use the official install.sh script from the Copilot CLI repository as requested by @pelikhan. This maintains security improvements while leveraging the official installer.
Implementation Details
Security Improvements Over Original
https://raw.githubusercontent.com/github/copilot-cli/main/install.shInstallation Pattern
Code Changes
pkg/workflow/copilot_engine.go-GenerateCopilotInstallerSteps()functionpkg/workflow/copilot_installer_test.go- Updated tests for new patternpkg/workflow/engine_includes_test.go- Updated test expectationspkg/workflow/codex_test.go- Updated test expectationsTest Results
Benefits
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Changeset
install.shdownloaded to a temporary file, executed, and removed. Tests updated to assert secure installer usage. Fixes [plan] Add SHA256 checksum verification for Copilot CLI installer script #6674Changeset
install.shdownloaded to a temporary file, executed, and removed. Tests updated to assert secure installer usage. Fixes [plan] Add SHA256 checksum verification for Copilot CLI installer script #6674