Add daily release update check to compile command by Copilot · Pull Request #7032 · github/gh-aw

Copilot · 2025-12-20T02:28:39Z

Update Check Feature for Compile Command

Implementation Complete ✅

Features

✅ Daily check - Only checks once per 24 hours, tracked in /tmp/gh-aw/gh-aw-last-update-check
✅ CI/MCP disabled - Automatically disabled in CI environments and MCP server mode
✅ Non-blocking - Runs in goroutine, doesn't slow down compilation
✅ Error handling - Silently ignores all connectivity/API errors
✅ go-gh integration - Uses existing github.com/cli/go-gh/v2 dependency
✅ User control - --no-check-update flag to disable manually
✅ Clear messaging - Shows update instructions: gh extension upgrade githubnext/gh-aw
✅ Robust version detection - Uses IsReleasedVersion helper for proper semantic versioning validation

Testing

Unit tests (6 test cases): Validate all helper functions, environment detection, timestamp tracking, and error handling
Integration tests (5 test scenarios): End-to-end verification with actual binary execution
- CI mode detection
- --no-check-update flag functionality
- Timestamp-based check frequency
- Development build detection
- Help text verification
Manual testing completed
Linting and formatting validated

Original prompt

The compile command should try to check for a release update once a day to detect a newer version.

disabled in ci mode / mcp server

only once a day, keep track in a temp location

non blocking, attempt download during compilation and show result if any. Ignore any connectivity error. Only attempt once a day.

use go-gh to query release

show message with instructions to update ("gh aw update")

support disabling through "--no-check-update"

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

pelikhan · 2025-12-20T02:39:50Z

@copilot make sure it only fails silently.

- Create update_check.go module with daily check logic - Add --no-check-update flag to compile command - Check disabled in CI/MCP server mode - Track last check time in temp directory - Use go-gh to query GitHub releases API - Non-blocking check with connectivity error handling - Display update message with upgrade instructions - Add comprehensive tests for update check functionality Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

- Verified --no-check-update flag works correctly - Confirmed CI mode detection works - Tested update check runs non-blocking - All linting and formatting checks pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-20T03:00:43Z

@copilot make sure it only fails silently.

Confirmed - all failure cases fail silently:

API/network errors (line 167-170): Logged to debug only, function returns
File write errors (line 140): Logged to debug only, continues
Panics (line 238-241): Recovered and logged to debug only
Version check failures: All return early with debug logging only

Debug logs (updateCheckLog.Printf) only appear when DEBUG env var is set. No errors are shown to users - they only see the update notification when a newer version is actually available.

The implementation already meets the requirement. (eb4c32d)

pelikhan · 2025-12-20T06:50:31Z

@copilot use isRelease helper to determine if it is a released build

- Export isReleasedVersion as IsReleasedVersion in pkg/workflow - Update update_check.go to use workflow.IsReleasedVersion - More robust check than simple "dev" string matching - Validates semantic versioning format and filters dev/dirty/test builds Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-20T07:01:02Z

@copilot use isRelease helper to determine if it is a released build

Done. Exported isReleasedVersion as IsReleasedVersion in pkg/workflow and updated update_check.go to use workflow.IsReleasedVersion(). This provides more robust version detection - validates semantic versioning format (x.y.z) and filters out builds containing "dev", "dirty", or "test" patterns. (0cd08bf)

pelikhan · 2025-12-20T07:20:55Z

@copilot add integration test

- Test update check disabled in CI mode - Test --no-check-update flag functionality - Test timestamp-based check frequency - Test development build detection - Test flag appears in help text - All tests use //go:build integration tag - Tests build actual binary and verify end-to-end behavior Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-20T07:26:38Z

@copilot add integration test

Added integration tests in update_check_integration_test.go covering:

CI mode detection (update check disabled)
--no-check-update flag functionality
Timestamp-based check frequency
Development build detection
Help text verification

Tests build the actual binary and verify end-to-end behavior using //go:build integration tag. All tests pass. (2607bca)

github-actions · 2025-12-20T13:09:42Z

🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰

github-actions · 2025-12-20T13:09:43Z

✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️

github-actions · 2025-12-20T13:09:43Z

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

github-actions · 2025-12-20T13:09:43Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2025-12-20T13:09:43Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2025-12-20T13:09:45Z

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

github-actions · 2025-12-20T13:09:46Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2025-12-20T13:12:08Z

Smoke Test Results

✅ File Writing: Created test file successfully
✅ Bash Tool: File read verification passed
❌ Safe Input gh Tool: Tool not available

Overall Status: FAIL

The safeinputs-gh tool is not available in the current workflow configuration.

Ahoy! This treasure was crafted by 🏴‍☠️ Smoke Copilot Safe Inputs fer issue #7032 🗺️

github-actions · 2025-12-20T13:12:13Z

Smoke Test Results

Last 2 merged PRs:

Add integration tests for safe output job configurations #7034: Add integration tests for safe output job configurations
Refactor: eliminate sanitization pipeline duplication between core and full modules #7031: Refactor: eliminate sanitization pipeline duplication

Test Results:

✅ GitHub MCP (reviewed PRs)
✅ File Writing (/tmp/gh-aw/agent/smoke-test-copilot-20394844112.txt)
✅ Bash Tool (file verified)
✅ Playwright MCP (page title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub")
❌ Safe Input gh Tool (no authentication in bash context)

Status: FAIL (gh tool not authenticated)

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall fer issue #7032 🗺️

github-actions · 2025-12-20T13:12:15Z

Smoke Test Results

Last 2 Merged PRs:

Add integration tests for safe output job configurations #7034: Add integration tests for safe output job configurations (by @Copilot, assigned @mnkiefer)
Refactor: eliminate sanitization pipeline duplication between core and full modules #7031: Refactor: eliminate sanitization pipeline duplication (by @Copilot, assigned @mnkiefer)

Test Results:

✅ GitHub MCP Testing
✅ File Writing Testing
✅ Bash Tool Testing
✅ GitHub MCP Default Toolset Testing (get_me correctly unavailable)
✅ Cache Memory Testing

Overall: PASS

cc: @pelikhan

📰 BREAKING: Report filed by Smoke Copilot fer issue #7032 🗺️

github-actions · 2025-12-20T13:12:35Z

OpenAI curl blocked: ✅
example.com blocked: ✅
GitHub MCP merged PRs: Add integration tests for safe output job configurations; Refactor: eliminate sanitization pipeline duplication between core and full modules ✅
File write/read /tmp/gh-aw/agent/smoke-test-codex-firewall-20394844099.txt: ✅
Network: SANDBOXED
Overall: PASS

🔥 Firewall tested by Smoke Codex Firewall fer issue #7032 🗺️

github-actions · 2025-12-20T13:12:53Z

PRs:

Add integration tests for safe output job configurations
Refactor: eliminate sanitization pipeline duplication between core and full modules
Tests: ✅ GitHub MCP PR fetch, ✅ file write/read /tmp/gh-aw/agent, ✅ Playwright title contains GitHub, ✅ cache memory file, ❌ safeinputs-gh (tool unavailable)
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex fer issue #7032 🗺️

github-actions · 2025-12-20T13:12:59Z

Smoke Test Results - Claude Sonnet 4.5

PRs Reviewed:

Add integration tests for safe output job configurations #7034: Add integration tests for safe output job configurations
Refactor: eliminate sanitization pipeline duplication between core and full modules #7031: Refactor: eliminate sanitization pipeline duplication

Tests:
✅ GitHub MCP - last 2 merged PRs retrieved
✅ File Writing - agent directory file created
✅ Bash Tool - file verification successful
✅ Playwright MCP - navigated to GitHub, title contains "GitHub"
✅ Cache Memory - test file created and verified
⚠️ Safe Input gh Tool - tool not available in current context

Status: PASS (5/6 tests successful)

💥 [THE END] — Illustrated by Smoke Claude fer issue #7032 🗺️

Initial plan

4df7bdd

Copilot AI assigned Copilot and pelikhan Dec 20, 2025

Copilot started work on behalf of pelikhan December 20, 2025 02:29 View session

Copilot AI and others added 2 commits December 20, 2025 02:46

Copilot AI changed the title ~~[WIP] Add daily release update check during compilation~~ Add daily release update check to compile command Dec 20, 2025

Copilot AI requested a review from pelikhan December 20, 2025 02:56

Copilot finished work on behalf of pelikhan December 20, 2025 02:56

Copilot started work on behalf of pelikhan December 20, 2025 02:56 View session

Copilot finished work on behalf of pelikhan December 20, 2025 03:01

Copilot started work on behalf of pelikhan December 20, 2025 06:51 View session

pelikhan marked this pull request as ready for review December 20, 2025 06:55

Copilot finished work on behalf of pelikhan December 20, 2025 07:02

Copilot started work on behalf of pelikhan December 20, 2025 07:21 View session

Copilot finished work on behalf of pelikhan December 20, 2025 07:27

pelikhan added the smoke label Dec 20, 2025

github-actions Bot added the smoke-copilot label Dec 20, 2025

github-actions Bot added the smoke-codex-firewall label Dec 20, 2025

github-actions Bot added the smoke-claude label Dec 20, 2025

pelikhan merged commit 4e0efe1 into main Dec 20, 2025
59 checks passed

pelikhan deleted the copilot/add-daily-release-check branch December 20, 2025 13:18

Conversation

Copilot AI commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update Check Feature for Compile Command

Implementation Complete ✅

Features

Testing

Uh oh!

pelikhan commented Dec 20, 2025

Uh oh!

Copilot AI commented Dec 20, 2025

Uh oh!

pelikhan commented Dec 20, 2025

Uh oh!

Copilot AI commented Dec 20, 2025

Uh oh!

pelikhan commented Dec 20, 2025

Uh oh!

Copilot AI commented Dec 20, 2025

Uh oh!

github-actions Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 20, 2025 • edited by agentic-workflows-dev Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 20, 2025

Smoke Test Results

Uh oh!

github-actions Bot commented Dec 20, 2025

Smoke Test Results

Uh oh!

github-actions Bot commented Dec 20, 2025

Smoke Test Results

Uh oh!

github-actions Bot commented Dec 20, 2025

Uh oh!

github-actions Bot commented Dec 20, 2025

Uh oh!

github-actions Bot commented Dec 20, 2025

Smoke Test Results - Claude Sonnet 4.5

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 20, 2025 •

edited

Loading

github-actions Bot commented Dec 20, 2025 •

edited

Loading

github-actions Bot commented Dec 20, 2025 •

edited

Loading

github-actions Bot commented Dec 20, 2025 •

edited

Loading

github-actions Bot commented Dec 20, 2025 •

edited

Loading

github-actions Bot commented Dec 20, 2025 •

edited

Loading

github-actions Bot commented Dec 20, 2025 •

edited by agentic-workflows-dev Bot

Loading

github-actions Bot commented Dec 20, 2025 •

edited

Loading