Remove obsolete action references and clean up actions build system#8055
Merged
Conversation
…s actions - Remove dependency mappings from getActionDependencies() - Remove buildSetupSafeOutputsAction() function - Remove special handling in buildAction() - Remove special cleaning logic in ActionsCleanCommand() - Update actions/README.md - Update specs/actions.md with current architecture - All tests passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Remove .gitignore entry for actions/setup-safe-outputs/js/ - Update developer instructions with current action structure Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove actions/setup-safe-inputs and actions/setup-safe-outputs
Remove obsolete setup-safe-inputs and setup-safe-outputs action references
Dec 29, 2025
pelikhan
reviewed
Dec 29, 2025
| @@ -376,25 +322,6 @@ func getActionDependencies(actionName string) []string { | |||
|
|
|||
| // Static dependencies for other actions | |||
| dependencyMap := map[string][]string{ | |||
Collaborator
There was a problem hiding this comment.
@copilot only a single action (actions/setup) is used. Clean out the rest.
Contributor
Author
There was a problem hiding this comment.
Fixed in f3b349f. Removed dependency mappings for non-existent actions (noop, minimize_comment, close_issue, close_pull_request, close_discussion).
Only actions/setup exists, remove references to noop, minimize_comment, close_issue, close_pull_request, and close_discussion from dependency mapping and developer instructions Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Remove obsolete setup-safe-inputs and setup-safe-outputs action references
Remove obsolete action references and clean up actions build system
Dec 29, 2025
pelikhan
reviewed
Dec 29, 2025
Comment on lines
154
to
183
| │ ├── noop/ # Noop safe output action | ||
| │ │ ├── action.yml # Action metadata | ||
| │ │ ├── index.js # Bundled output (committed) | ||
| │ │ ├── src/ # Source files | ||
| │ │ │ └── index.js # Source that references FILES constant | ||
| │ │ └── README.md # Action-specific docs | ||
| │ ├── minimize_comment/ # Minimize comment action | ||
| │ │ ├── action.yml # Action metadata | ||
| │ │ ├── index.js # Bundled output (committed) | ||
| │ │ ├── src/ # Source files | ||
| │ │ │ └── index.js # Source that references FILES constant | ||
| │ │ └── README.md # Action-specific docs | ||
| │ ├── close_issue/ # Close issue action | ||
| │ │ ├── action.yml # Action metadata | ||
| │ │ ├── index.js # Bundled output (committed) | ||
| │ │ ├── src/ # Source files | ||
| │ │ │ └── index.js # Source that references FILES constant | ||
| │ │ └── README.md # Action-specific docs | ||
| │ ├── close_pull_request/ # Close pull request action | ||
| │ │ ├── action.yml # Action metadata | ||
| │ │ ├── index.js # Bundled output (committed) | ||
| │ │ ├── src/ # Source files | ||
| │ │ │ └── index.js # Source that references FILES constant | ||
| │ │ └── README.md # Action-specific docs | ||
| │ ├── close_discussion/ # Close discussion action | ||
| │ │ ├── action.yml # Action metadata | ||
| │ │ ├── index.js # Bundled output (committed) | ||
| │ │ ├── src/ # Source files | ||
| │ │ │ └── index.js # Source that references FILES constant | ||
| │ │ └── README.md # Action-specific docs |
Comment on lines
350
to
358
| "noop": { | ||
| "load_agent_output.cjs", | ||
| }, | ||
| "minimize_comment": { | ||
| "load_agent_output.cjs", | ||
| }, | ||
| "close_issue": { | ||
| "close_entity_helpers.cjs", | ||
| }, |
Collaborator
There was a problem hiding this comment.
@copilot those actions are not needed only actions/setup is used
Contributor
Author
There was a problem hiding this comment.
Fixed in ce4684f. Updated the dependency mapping example code to match the actual implementation that only handles the setup action.
- Remove directory layout entries for noop, minimize_comment, close_issue, close_pull_request, close_discussion - Update dependency mapping example to match actual code - Update summary section to reflect only setup action exists Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup obsolete action references
The
actions/setup-safe-inputsandactions/setup-safe-outputsdirectories were consolidated intoactions/setup, but references remained throughout the codebase. Additionally, documentation incorrectly referenced non-existent actions (noop, minimize_comment, close_issue, close_pull_request, close_discussion). This PR cleans up all obsolete references to reflect that onlyactions/setupexists.Changes
pkg/cli/actions_build_command.gobuildSetupSafeOutputsAction()function and dependency mappings for obsolete actionsActionsCleanCommand()andbuildAction()by removing special-case handlinggetActionDependencies()to only handle thesetupactionDocumentation updates
actions/README.md: Removed obsolete action sections, updated examples to use./actions/setupspecs/actions.md:setupactionsetupaction exists.github/instructions/developer.instructions.md: Updated directory structure to show only thesetupactionCleanup
.gitignore: Removedactions/setup-safe-outputs/js/entryNet: -138 lines, simplified build system to accurately reflect actual action structure with no functional changes.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.