Commit 4aecc93
committed
fix(move-tables): address Copilot review comments on #1704 (#8209)
- Add mgtr.checkAbort() at top of T3 drain poll loop so abort/panic
stops the drain immediately instead of waiting the full 60s timeout
- Assert NoError on CREATE DATABASE IF NOT EXISTS in applier_test.go
SetupSuite (was silently discarding the error with _, _ =)
- Rewrite T2 comment to frame @@GLOBAL.gtid_executed as a readability
divergence (making scope unambiguous in SQL) rather than asserting
session-vs-global semantics that may not hold in MySQL 8.0
Ref: database-infrastructure#82091 parent 54652ab commit 4aecc93
2 files changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
304 | | - | |
| 304 | + | |
| 305 | + | |
305 | 306 | | |
306 | 307 | | |
307 | 308 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
989 | 989 | | |
990 | 990 | | |
991 | 991 | | |
992 | | - | |
993 | | - | |
994 | | - | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
995 | 995 | | |
996 | 996 | | |
997 | 997 | | |
| |||
1022 | 1022 | | |
1023 | 1023 | | |
1024 | 1024 | | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
1025 | 1028 | | |
1026 | 1029 | | |
1027 | 1030 | | |
| |||
0 commit comments