install failpoint

Author: chriskirkland

go.mod

@@ -55,6 +55,7 @@ require (
 	github.com/opencontainers/go-digest v1.0.0 // indirect
 	github.com/opencontainers/image-spec v1.1.1 // indirect
 	github.com/pingcap/errors v0.11.5-0.20260310054046-9c8b3586e4b2 // indirect
+	github.com/pingcap/failpoint v0.0.0-20260521055755-e7642935314f // indirect
 	github.com/pingcap/log v1.1.1-0.20260227082333-572e590d08f1 // indirect
 	github.com/pingcap/tidb/pkg/parser v0.0.0-20260504140133-511dba1dbe17 // indirect
 	github.com/pkg/errors v0.9.1 // indirect

go.sum

@@ -117,6 +117,8 @@ github.com/pingcap/errors v0.11.5-0.20240311024730-e056997136bb h1:3pSi4EDG6hg0o
 github.com/pingcap/errors v0.11.5-0.20240311024730-e056997136bb/go.mod h1:X2r9ueLEUZgtx2cIogM0v4Zj5uvvzhuuiu7Pn8HzMPg=
 github.com/pingcap/errors v0.11.5-0.20260310054046-9c8b3586e4b2 h1:cLgCk5mwDG9lDH+dPK8TmEliTjyGJwwKN0qevWAl8IY=
 github.com/pingcap/errors v0.11.5-0.20260310054046-9c8b3586e4b2/go.mod h1:ktAJCA9lxrHHjVyVl2pKJFvzBnq2eZbb+CUOjBRPlXo=
+github.com/pingcap/failpoint v0.0.0-20260521055755-e7642935314f h1:cDo4qNgaQc2POMWTXjNrMA7yySdIF/d1AaW8kOA7qOs=
+github.com/pingcap/failpoint v0.0.0-20260521055755-e7642935314f/go.mod h1:jimwlLpI/XtwQdlZML15HS+j4rirvwZM0GLY07wwgOo=
 github.com/pingcap/log v1.1.1-0.20230317032135-a0d097d16e22 h1:2SOzvGvE8beiC1Y4g9Onkvu6UmuBBOeWRGQEjJaT/JY=
 github.com/pingcap/log v1.1.1-0.20230317032135-a0d097d16e22/go.mod h1:DWQW5jICDR7UJh4HtxXSM20Churx4CQL0fwL/SoOSA4=
 github.com/pingcap/log v1.1.1-0.20260227082333-572e590d08f1 h1:A2bEfgSb7hLwR9mxDszgGKweF+xY9YoTDG+8RjdFjDE=

go/base/context.go

@@ -305,6 +305,8 @@ type MigrationContext struct {
 		DrainGTID mysql.BinlogCoordinates // Source @@gtid_executed captured immediately after the source RENAME TABLE; the applier drains until it reaches this coordinate (move-tables only).
 	}
 
+	UnsafeFailPointsEnabled bool
+
 	Log Logger
 }
 

go/cmd/gh-ost/main.go

@@ -197,6 +197,9 @@ func main() {
 	flag.StringVar(&migrationContext.MoveTables.TargetDatabase, "target-database", "", "Target MySQL database name for --move-tables mode. If not provided, uses the same database name as the source connection")
 	flag.BoolVar(&migrationContext.MoveTables.AllowOnSourcePrimary, "allow-on-source-primary", false, "allow --move-tables to read (schema, row copy, binlog) from the source cluster's primary. By default gh-ost stops if --host is the primary; prefer pointing --host at a replica to spare the primary the copy load.")
 
+	// unsafe fail points, for integration testing purposes
+	flag.BoolVar(&migrationContext.UnsafeFailPointsEnabled, "unsafe-fail-points-enabled", false, "UNSAFE: Enable fail points for integration testing purposes. Do not use in production.")
+
 	flag.CommandLine.SetOutput(os.Stdout)
 	flag.Parse()
 	cutOverLockTimeoutUserSpecified := false

go/logic/migrator.go

@@ -21,6 +21,8 @@ import (
 	"github.com/github/gh-ost/go/binlog"
 	"github.com/github/gh-ost/go/mysql"
 	"github.com/github/gh-ost/go/sql"
+
+	"github.com/pingcap/failpoint"
 )
 
 var (
@@ -2869,3 +2871,13 @@ func (mgtr *Migrator) teardown() {
 		mgtr.sourcePrimaryDB.Close()
 	}
 }
+
+func (mgtr *Migrator) newFailPoint(name string) {
+	if mgtr.migrationContext.UnsafeFailPointsEnabled {
+		mgtr.migrationContext.Log.Debugf("Injecting fail point: %s", name)
+
+		failpoint.Inject(name, func(val failpoint.Value) {
+			panic(fmt.Sprintf("encountered fail point: '%s'", name))
+		})
+	}
+}

localtests/move-tables-test.sh

@@ -7,6 +7,8 @@
 # Usage: localtests/test/sh [filter]
 # By default, runs all move-tables tests. Given filter, will only run tests matching given regep
 
+set -x
+
 repo_root=$(git rev-parse --show-toplevel)
 script_path="$repo_root/script/move-tables"
 tests_path=$(dirname $0)/move-tables
@@ -453,6 +455,26 @@ test_single() {
     done
 }
 
+install_failpoint() {
+    pushd $repo_root/../..
+
+    if [ ! -d "pingcap/failpoint" ]; then
+        echo "⚙️ Installing failpoint"
+        mkdir -p pingcap/failpoint
+        git clone https://github.com/pingcap/failpoint.git pingcap/failpoint
+        cd pingcap/failpoint
+        make
+    else
+        bin/failpoint-ctl disable
+    fi
+
+    echo "⚙️ Enabling failpoint"
+    bin/failpoint-ctl enable
+
+    echo "✅ Successfully enabled failpoint"
+    popd
+}
+
 build_binary() {
     echo "Building"
     rm -f $default_ghost_binary
@@ -471,6 +493,7 @@ build_binary() {
 }
 
 test_all() {
+    install_failpoint
     build_binary
     test_dirs=$(find "$tests_path" -mindepth 1 -maxdepth 1 ! -path . -type d | grep "$test_pattern" | sort)
     while read -r test_dir; do