Skip to content

Commit 85edd14

Browse files
committed
2nd round of review comments
1 parent c7423cd commit 85edd14

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

  • localtests/move-tables

localtests/move-tables/resume-panic-on-row-copy/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ echo -e "\n\n\n\n\n"
104104

105105
echo "⚙️ Validating checkpointed state after resumed migration..."
106106

107-
# validate we processed a single row-copy chunk (10 rows) and there are 20 total to process
107+
# validate we processed the rest of the 20 rows to copy
108108
rows_copied=$(mysql-exec target primary $database -Ne "SELECT gh_ost_rows_copied FROM _${table_name}_ghk ORDER BY gh_ost_chk_id DESC LIMIT 1;")
109109
if [ $rows_copied -ne 20 ]; then
110110
echo "ERROR: Expected last checkpoint to show 20 rows copied."

localtests/move-tables/single-with-hooks/test.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11

22
#!/bin/bash
33
# Custom test:
4-
# - panic during row copy stage, prior to cutover
5-
# - resume and complete the migration
4+
# Executes migration with custom hooks (on-row-copy-complete, on-before-cut-over, on-success)
5+
# which are executed at different stages of the migration and validate the environment variables
6+
# expected to be available to the respective hooks.
67

78
database=test
89
table_name=gh_ost_test

0 commit comments

Comments
 (0)