Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: chriskirkland

go/base/context.go

@@ -1169,18 +1169,16 @@ func WithFailPointWait(wait time.Duration) FailPointOpt {
 
 func (mctx *MigrationContext) NewFailPoint(name string, opts ...FailPointOpt) {
 	if mctx.UnsafeFailPointsEnabled {
-		mctx.Log.Debugf("[TEST] Injecting fail point: '%s'", name)
-
 		var fpo failPointOpts
 		for _, opt := range opts {
 			opt(&fpo)
 		}
 
 		failpoint.Inject(name, func(_ failpoint.Value) {
+			mctx.Log.Debugf("[TEST] Encountered fail point: '%s'", name)
 			if fpo.wait > 0 {
-				<-time.After(fpo.wait)
+				time.Sleep(fpo.wait)
 			}
-
 			panic(fmt.Sprintf("[TEST] Encountered fail point: '%s'", name))
 		})
 	}

localtests/move-tables-test.sh

@@ -210,7 +210,7 @@ build_ghost_command() {
     --execute ${extra_args[@]}"
 
     if [ -n "$GO_FAILPOINTS" ]; then
-        cmd="GO_FAILPOINTS=\"$GO_FAILPOINTS\" $cmd --unsafe-fail-points-enabled"
+        cmd="GO_FAILPOINTS=\"$GO_FAILPOINTS\" $cmd"
     fi
 }
 

localtests/move-tables/resume-panic-before-drain-complete/test.sh

@@ -61,7 +61,7 @@ if [ $? -gt 0 ]; then
 fi
 
 # Table not writeable on source
-mysql-exec target source $database -sNe "INSERT INTO ${table_name} VALUES (NULL, 1021, 2001, 2400001, 201, 1700000041, 1700000041);"
+mysql-exec source primary $database -sNe "INSERT INTO ${table_name} VALUES (NULL, 1021, 2001, 2400001, 201, 1700000041, 1700000041);"
 if [ $? -eq 0 ]; then
     echo "ERROR: Table '${table_name}' was writeable on source but should not be!."
     return 1
@@ -98,7 +98,7 @@ cmd="$cmd --resume"
 bash -c "$cmd" >>$test_logfile 2>&1
 ghost_result=$?
 
-if [ $ghost_result -neq 0 ]; then
+if [ $ghost_result -ne 0 ]; then
     echo "ERROR: gh-ost should have succeeded but did not. ($ghost_result)"
     return 1
 fi

localtests/move-tables/resume-panic-before-on-success-hook/test.sh

@@ -70,7 +70,7 @@ if [ $? -gt 0 ]; then
 fi
 
 # Table not writeable on source
-mysql-exec target source $database -sNe "INSERT INTO ${table_name} VALUES (NULL, 1021, 2001, 2400001, 201, 1700000041, 1700000041);"
+mysql-exec source primary $database -sNe "INSERT INTO ${table_name} VALUES (NULL, 1021, 2001, 2400001, 201, 1700000041, 1700000041);"
 if [ $? -eq 0 ]; then
     echo "ERROR: Table '${table_name}' was writeable on source but should not be!."
     return 1
@@ -121,7 +121,7 @@ cmd="$cmd --resume"
 bash -c "$cmd" >>$test_logfile 2>&1
 ghost_result=$?
 
-if [ $ghost_result -neq 0 ]; then
+if [ $ghost_result -ne 0 ]; then
     echo "ERROR: gh-ost should have succeeded but did not. ($ghost_result)"
     return 1
 fi

localtests/move-tables/resume-panic-on-row-copy/test.sh

@@ -84,7 +84,7 @@ cmd="$cmd --resume"
 bash -c "$cmd" >>$test_logfile 2>&1
 ghost_result=$?
 
-if [ $ghost_result -neq 0 ]; then
+if [ $ghost_result -ne 0 ]; then
     echo "ERROR: gh-ost should have succeeded but did not. ($ghost_result)"
     return 1
 fi