nil checking

Author: timvaillancourt

go/base/context.go

@@ -356,6 +356,9 @@ func (this *MigrationContext) GetVoluntaryLockName() string {
 
 // RequiresBinlogFormatChange is `true` when the original binlog format isn't `ROW`
 func (this *MigrationContext) RequiresBinlogFormatChange() bool {
+	if this.InspectorServerInfo == nil {
+		return true
+	}
 	return this.InspectorServerInfo.BinlogFormat != "ROW"
 }
 

go/logic/server.go

@@ -178,18 +178,22 @@ help                                 # This message
 			return NoPrintStatusRule, fmt.Errorf("coordinates are read-only")
 		}
 	case "applier":
-		if this.migrationContext.ApplierConnectionConfig != nil && this.migrationContext.ApplierConnectionConfig.ImpliedKey != nil {
-			fmt.Fprintf(writer, "Host: %s, Version: %s\n",
+		if this.migrationContext.ApplierConnectionConfig != nil && this.migrationContext.ApplierConnectionConfig.ImpliedKey != nil &&
+			this.migrationContext.ApplierServerInfo != nil {
+			fmt.Fprintf(writer, "Host: %s, Version: %s (%s)\n",
 				this.migrationContext.ApplierConnectionConfig.ImpliedKey.String(),
 				this.migrationContext.ApplierServerInfo.Version,
+				this.migrationContext.ApplierServerInfo.VersionComment,
 			)
 		}
 		return NoPrintStatusRule, nil
 	case "inspector":
-		if this.migrationContext.InspectorConnectionConfig != nil && this.migrationContext.InspectorConnectionConfig.ImpliedKey != nil {
-			fmt.Fprintf(writer, "Host: %s, Version: %s\n",
+		if this.migrationContext.InspectorConnectionConfig != nil && this.migrationContext.InspectorConnectionConfig.ImpliedKey != nil &&
+			this.migrationContext.InspectorServerInfo != nil {
+			fmt.Fprintf(writer, "Host: %s, Version: %s (%s)\n",
 				this.migrationContext.InspectorConnectionConfig.ImpliedKey.String(),
 				this.migrationContext.InspectorServerInfo.Version,
+				this.migrationContext.InspectorServerInfo.VersionComment,
 			)
 		}
 		return NoPrintStatusRule, nil