Skip to content

Commit ed0eba9

Browse files
committed
add back ReplicaTermFor
1 parent 99626bc commit ed0eba9

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

go/logic/inspect.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ func (this *Inspector) applyBinlogFormat() error {
384384

385385
// validateBinlogs checks that binary log configuration is good to go
386386
func (this *Inspector) validateBinlogs() error {
387-
query := `select @@global.log_bin, @@global.binlog_format`
387+
query := `select /* gh-ost */@@global.log_bin, @@global.binlog_format`
388388
var hasBinaryLogs bool
389389
if err := this.db.QueryRow(query).Scan(&hasBinaryLogs, &this.migrationContext.OriginalBinlogFormat); err != nil {
390390
return err

go/mysql/utils.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,12 @@ func GetReplicationBinlogCoordinates(dbVersion string, db *gosql.DB, gtid bool)
173173
}
174174
} else {
175175
readBinlogCoordinates = NewFileBinlogCoordinates(
176-
m.GetString("Master_Log_File"),
177-
m.GetInt64("Read_Master_Log_Pos"),
176+
m.GetString(ReplicaTermFor(dbVersion, "Master_Log_File")),
177+
m.GetInt64(ReplicaTermFor(dbVersion, "Read_Master_Log_Pos")),
178178
)
179179
executeBinlogCoordinates = NewFileBinlogCoordinates(
180-
m.GetString("Relay_Master_Log_File"),
181-
m.GetInt64("Exec_Master_Log_Pos"),
180+
m.GetString(ReplicaTermFor(dbVersion, "Relay_Master_Log_File")),
181+
m.GetInt64(ReplicaTermFor(dbVersion, "Exec_Master_Log_Pos")),
182182
)
183183
}
184184
return nil

0 commit comments

Comments
 (0)