Skip to content

Commit f5b7fb0

Browse files
Juan Manuel FernandezGonlo2
authored andcommitted
Explained better method logic
1 parent 2961cad commit f5b7fb0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

go/logic/applier.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -644,8 +644,8 @@ func (this *Applier) CreateTriggersOriginalTable() error {
644644
}()
645645
}
646646

647-
// DropTriggersOldTable Drop triggers from the old table
648-
func (this *Applier) DropTriggersOldTable() error {
647+
// DropTriggersOldTableIfExists Drop triggers from the old table if them exists
648+
func (this *Applier) DropTriggersOldTableIfExists() error {
649649
prefix := this.makeTriggerPrefix()
650650

651651
dropDeleteTrigger := fmt.Sprintf(

go/logic/migrator.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ func (this *Migrator) cutOverTrigger() (err error) {
693693

694694
this.waitForStopWrites()
695695

696-
defer this.applier.DropTriggersOldTable()
696+
defer this.applier.DropTriggersOldTableIfExists()
697697

698698
log.Infof(
699699
"Creating triggers for %s.%s",
@@ -735,7 +735,7 @@ CompareAddedRow:
735735
if err := this.retryOperation(this.applier.SwapTables); err != nil {
736736
return err
737737
}
738-
if err := this.retryOperation(this.applier.DropTriggersOldTable); err != nil {
738+
if err := this.retryOperation(this.applier.DropTriggersOldTableIfExists); err != nil {
739739
return err
740740
}
741741

0 commit comments

Comments
 (0)