[WIP] [WIP] Address feedback on OSS logging adapter for http implementation (#2264)

* Initial plan

* Fix BaseDeps.Logger and BaseDeps.Metrics to return safe defaults when Obsv is nil

Agent-Logs-Url: https://github.com/github/github-mcp-server/sessions/53221b0b-abb4-4138-a147-3ce9e13b379a

Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>

* Fix nil metrics in server.go by passing metrics.NewNoopMetrics() to NewExporters

Agent-Logs-Url: https://github.com/github/github-mcp-server/sessions/53221b0b-abb4-4138-a147-3ce9e13b379a

Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
Co-authored-by: Matt Holloway <mattdholloway@github.com>

Author: Copilot

pkg/github/dependencies.go

@@ -189,15 +189,15 @@ func (d BaseDeps) GetContentWindowSize() int { return d.ContentWindowSize }
 // Logger implements ToolDependencies.
 func (d BaseDeps) Logger(_ context.Context) *slog.Logger {
 	if d.Obsv == nil {
-		return nil
+		return slog.New(slog.DiscardHandler)
 	}
 	return d.Obsv.Logger()
 }
 
 // Metrics implements ToolDependencies.
 func (d BaseDeps) Metrics(ctx context.Context) metrics.Metrics {
 	if d.Obsv == nil {
-		return nil
+		return metrics.NewNoopMetrics()
 	}
 	return d.Obsv.Metrics(ctx)
 }

pkg/http/server.go

@@ -18,6 +18,7 @@ import (
 	"github.com/github/github-mcp-server/pkg/inventory"
 	"github.com/github/github-mcp-server/pkg/lockdown"
 	"github.com/github/github-mcp-server/pkg/observability"
+	"github.com/github/github-mcp-server/pkg/observability/metrics"
 	"github.com/github/github-mcp-server/pkg/scopes"
 	"github.com/github/github-mcp-server/pkg/translations"
 	"github.com/github/github-mcp-server/pkg/utils"
@@ -107,7 +108,7 @@ func RunHTTPServer(cfg ServerConfig) error {
 
 	featureChecker := createHTTPFeatureChecker()
 
-	obs, err := observability.NewExporters(logger, observability.NewNoopMetrics())
+	obs, err := observability.NewExporters(logger, metrics.NewNoopMetrics())
 	if err != nil {
 		return fmt.Errorf("failed to create observability exporters: %w", err)
 	}