Skip to content

Commit 35fedd9

Browse files
committed
add assortions and check for nil response
1 parent 99ed197 commit 35fedd9

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

pkg/github/minimal_types.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,10 @@ func convertToMinimalIssueComment(comment *github.IssueComment) MinimalIssueComm
354354
func convertToMinimalFileContentResponse(resp *github.RepositoryContentResponse) MinimalFileContentResponse {
355355
m := MinimalFileContentResponse{}
356356

357+
if resp == nil {
358+
return m
359+
}
360+
357361
if c := resp.Content; c != nil {
358362
m.Content = &MinimalFileContent{
359363
Name: c.GetName(),

pkg/github/repositories_test.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1442,10 +1442,19 @@ func Test_CreateOrUpdateFile(t *testing.T) {
14421442
assert.Equal(t, tc.expectedContent.Content.GetName(), returnedContent.Content.Name)
14431443
assert.Equal(t, tc.expectedContent.Content.GetPath(), returnedContent.Content.Path)
14441444
assert.Equal(t, tc.expectedContent.Content.GetSHA(), returnedContent.Content.SHA)
1445+
assert.Equal(t, tc.expectedContent.Content.GetSize(), returnedContent.Content.Size)
1446+
assert.Equal(t, tc.expectedContent.Content.GetHTMLURL(), returnedContent.Content.HTMLURL)
14451447

14461448
// Verify commit
14471449
assert.Equal(t, tc.expectedContent.Commit.GetSHA(), returnedContent.Commit.SHA)
14481450
assert.Equal(t, tc.expectedContent.Commit.GetMessage(), returnedContent.Commit.Message)
1451+
assert.Equal(t, tc.expectedContent.Commit.GetHTMLURL(), returnedContent.Commit.HTMLURL)
1452+
1453+
// Verify commit author
1454+
require.NotNil(t, returnedContent.Commit.Author)
1455+
assert.Equal(t, tc.expectedContent.Commit.Author.GetName(), returnedContent.Commit.Author.Name)
1456+
assert.Equal(t, tc.expectedContent.Commit.Author.GetEmail(), returnedContent.Commit.Author.Email)
1457+
assert.NotEmpty(t, returnedContent.Commit.Author.Date)
14491458
})
14501459
}
14511460
}

0 commit comments

Comments
 (0)