move instructions.go and tests from github package to inventory package

Author: tommaso-moro

pkg/github/instructions.go pkg/inventory/instructions.gopkg/github/instructions.go renamed to pkg/inventory/instructions.go

@@ -1,13 +1,13 @@
-package github
+package inventory
 
 import (
 	"os"
 	"slices"
 	"strings"
 )
 
-// GenerateInstructions creates server instructions based on enabled toolsets
-func GenerateInstructions(enabledToolsets []string) string {
+// generateInstructions creates server instructions based on enabled toolsets
+func generateInstructions(enabledToolsets []ToolsetID) string {
 	// For testing - add a flag to disable instructions
 	if os.Getenv("DISABLE_INSTRUCTIONS") == "true" {
 		return "" // Baseline mode
@@ -16,7 +16,7 @@ func GenerateInstructions(enabledToolsets []string) string {
 	var instructions []string
 
 	// Core instruction - always included if context toolset enabled
-	if slices.Contains(enabledToolsets, "context") {
+	if slices.Contains(enabledToolsets, ToolsetID("context")) {
 		instructions = append(instructions, "Always call 'get_me' first to understand current user permissions and context.")
 	}
 
@@ -48,27 +48,27 @@ Tool usage guidance:
 }
 
 // getToolsetInstructions returns specific instructions for individual toolsets
-func getToolsetInstructions(toolset string, enabledToolsets []string) string {
+func getToolsetInstructions(toolset ToolsetID, enabledToolsets []ToolsetID) string {
 	switch toolset {
-	case "pull_requests":
+	case ToolsetID("pull_requests"):
 		pullRequestInstructions := `## Pull Requests
 
 PR review workflow: Always use 'pull_request_review_write' with method 'create' to create a pending review, then 'add_comment_to_pending_review' to add comments, and finally 'pull_request_review_write' with method 'submit_pending' to submit the review for complex reviews with line-specific comments.`
-		if slices.Contains(enabledToolsets, "repos") {
+		if slices.Contains(enabledToolsets, ToolsetID("repos")) {
 			pullRequestInstructions += `
 
 Before creating a pull request, search for pull request templates in the repository. Template files are called pull_request_template.md or they're located in '.github/PULL_REQUEST_TEMPLATE' directory. Use the template content to structure the PR description and then call create_pull_request tool.`
 		}
 		return pullRequestInstructions
-	case "issues":
+	case ToolsetID("issues"):
 		return `## Issues
 
 Check 'list_issue_types' first for organizations to use proper issue types. Use 'search_issues' before creating new issues to avoid duplicates. Always set 'state_reason' when closing issues.`
-	case "discussions":
+	case ToolsetID("discussions"):
 		return `## Discussions
 		
 Use 'list_discussion_categories' to understand available categories before creating discussions. Filter by category for better organization.`
-	case "projects":
+	case ToolsetID("projects"):
 		return `## Projects
 
 Workflow: 1) list_project_fields (get field IDs), 2) list_project_items (with pagination), 3) optional updates.

pkg/github/instructions_test.go pkg/inventory/instructions_test.gopkg/github/instructions_test.go renamed to pkg/inventory/instructions_test.go

@@ -1,4 +1,4 @@
-package github
+package inventory
 
 import (
 	"os"
@@ -9,49 +9,49 @@ import (
 func TestGenerateInstructions(t *testing.T) {
 	tests := []struct {
 		name            string
-		enabledToolsets []string
+		enabledToolsets []ToolsetID
 		expectedEmpty   bool
 	}{
 		{
 			name:            "empty toolsets",
-			enabledToolsets: []string{},
+			enabledToolsets: []ToolsetID{},
 			expectedEmpty:   false,
 		},
 		{
 			name:            "only context toolset",
-			enabledToolsets: []string{"context"},
+			enabledToolsets: []ToolsetID{"context"},
 			expectedEmpty:   false,
 		},
 		{
 			name:            "pull requests toolset",
-			enabledToolsets: []string{"pull_requests"},
+			enabledToolsets: []ToolsetID{"pull_requests"},
 			expectedEmpty:   false,
 		},
 		{
 			name:            "issues toolset",
-			enabledToolsets: []string{"issues"},
+			enabledToolsets: []ToolsetID{"issues"},
 			expectedEmpty:   false,
 		},
 		{
 			name:            "discussions toolset",
-			enabledToolsets: []string{"discussions"},
+			enabledToolsets: []ToolsetID{"discussions"},
 			expectedEmpty:   false,
 		},
 		{
 			name:            "multiple toolsets (context + pull_requests)",
-			enabledToolsets: []string{"context", "pull_requests"},
+			enabledToolsets: []ToolsetID{"context", "pull_requests"},
 			expectedEmpty:   false,
 		},
 		{
 			name:            "multiple toolsets (issues + pull_requests)",
-			enabledToolsets: []string{"issues", "pull_requests"},
+			enabledToolsets: []ToolsetID{"issues", "pull_requests"},
 			expectedEmpty:   false,
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			result := GenerateInstructions(tt.enabledToolsets)
+			result := generateInstructions(tt.enabledToolsets)
 
 			if tt.expectedEmpty {
 				if result != "" {
@@ -70,25 +70,25 @@ func TestGenerateInstructionsWithDisableFlag(t *testing.T) {
 	tests := []struct {
 		name            string
 		disableEnvValue string
-		enabledToolsets []string
+		enabledToolsets []ToolsetID
 		expectedEmpty   bool
 	}{
 		{
 			name:            "DISABLE_INSTRUCTIONS=true returns empty",
 			disableEnvValue: "true",
-			enabledToolsets: []string{"context", "issues", "pull_requests"},
+			enabledToolsets: []ToolsetID{"context", "issues", "pull_requests"},
 			expectedEmpty:   true,
 		},
 		{
 			name:            "DISABLE_INSTRUCTIONS=false returns normal instructions",
 			disableEnvValue: "false",
-			enabledToolsets: []string{"context"},
+			enabledToolsets: []ToolsetID{"context"},
 			expectedEmpty:   false,
 		},
 		{
 			name:            "DISABLE_INSTRUCTIONS unset returns normal instructions",
 			disableEnvValue: "",
-			enabledToolsets: []string{"issues"},
+			enabledToolsets: []ToolsetID{"issues"},
 			expectedEmpty:   false,
 		},
 	}
@@ -112,7 +112,7 @@ func TestGenerateInstructionsWithDisableFlag(t *testing.T) {
 				os.Setenv("DISABLE_INSTRUCTIONS", tt.disableEnvValue)
 			}
 
-			result := GenerateInstructions(tt.enabledToolsets)
+			result := generateInstructions(tt.enabledToolsets)
 
 			if tt.expectedEmpty {
 				if result != "" {
@@ -131,20 +131,20 @@ func TestGetToolsetInstructions(t *testing.T) {
 	tests := []struct {
 		toolset              string
 		expectedEmpty        bool
-		enabledToolsets      []string
+		enabledToolsets      []ToolsetID
 		expectedToContain    string
 		notExpectedToContain string
 	}{
 		{
 			toolset:           "pull_requests",
 			expectedEmpty:     false,
-			enabledToolsets:   []string{"pull_requests", "repos"},
+			enabledToolsets:   []ToolsetID{"pull_requests", "repos"},
 			expectedToContain: "pull_request_template.md",
 		},
 		{
 			toolset:              "pull_requests",
 			expectedEmpty:        false,
-			enabledToolsets:      []string{"pull_requests"},
+			enabledToolsets:      []ToolsetID{"pull_requests"},
 			notExpectedToContain: "pull_request_template.md",
 		},
 		{
@@ -163,7 +163,7 @@ func TestGetToolsetInstructions(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.toolset, func(t *testing.T) {
-			result := getToolsetInstructions(tt.toolset, tt.enabledToolsets)
+			result := getToolsetInstructions(ToolsetID(tt.toolset), tt.enabledToolsets)
 			if tt.expectedEmpty {
 				if result != "" {
 					t.Errorf("Expected empty result for toolset '%s', but got: %s", tt.toolset, result)