Skip to content

Commit 704faf4

Browse files
committed
fix: add authorAssociation to IssueFragment (GraphQL path)
Adds missing authorAssociation field to IssueFragment GraphQL struct and populates it in fragmentToMinimalIssue(), fixing the missing author_association field in list_issues responses from the GraphQL path. The REST path already correctly sets this via convertToMinimalIssue(). Fixes #2250.
1 parent 2a1eaac commit 704faf4

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

pkg/github/issues.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ type IssueFragment struct {
111111
DatabaseID int64
112112

113113
Author struct {
114-
Login githubv4.String
114+
Login githubv4.String
115+
Association githubv4.String
115116
}
116117
CreatedAt githubv4.DateTime
117118
UpdatedAt githubv4.DateTime

pkg/github/minimal_types.go

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -387,16 +387,17 @@ func convertToMinimalIssue(issue *github.Issue) MinimalIssue {
387387

388388
func fragmentToMinimalIssue(fragment IssueFragment) MinimalIssue {
389389
m := MinimalIssue{
390-
Number: int(fragment.Number),
391-
Title: sanitize.Sanitize(string(fragment.Title)),
392-
Body: sanitize.Sanitize(string(fragment.Body)),
393-
State: string(fragment.State),
394-
Comments: int(fragment.Comments.TotalCount),
395-
CreatedAt: fragment.CreatedAt.Format(time.RFC3339),
396-
UpdatedAt: fragment.UpdatedAt.Format(time.RFC3339),
390+
Number: int(fragment.Number),
391+
Title: sanitize.Sanitize(string(fragment.Title)),
392+
Body: sanitize.Sanitize(string(fragment.Body)),
393+
State: string(fragment.State),
394+
Comments: int(fragment.Comments.TotalCount),
395+
CreatedAt: fragment.CreatedAt.Format(time.RFC3339),
396+
UpdatedAt: fragment.UpdatedAt.Format(time.RFC3339),
397397
User: &MinimalUser{
398398
Login: string(fragment.Author.Login),
399399
},
400+
AuthorAssociation: string(fragment.Author.Association),
400401
}
401402

402403
for _, label := range fragment.Labels.Nodes {

0 commit comments

Comments
 (0)