Merge branch 'main' into get_check_runs

Author: kaitlin-duolingo

.github/workflows/code-scanning.yml

@@ -74,6 +74,18 @@ jobs:
           go-version: ${{ fromJSON(steps.resolve-environment.outputs.environment).configuration.go.version }}
           cache: false
 
+      - name: Set up Node.js
+        if: matrix.language == 'go'
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: ui/package-lock.json
+
+      - name: Build UI
+        if: matrix.language == 'go'
+        run: script/build-ui
+
       - name: Autobuild
         uses: github/codeql-action/autobuild@v4
 

.github/workflows/docker-publish.yml

@@ -93,9 +93,14 @@ jobs:
           key: ${{ runner.os }}-go-build-cache-${{ hashFiles('**/go.sum') }}
 
       - name: Inject go-build-cache
-        uses: reproducible-containers/buildkit-cache-dance@4b2444fec0c0fb9dbf175a96c094720a692ef810 # v2.1.4
+        uses: reproducible-containers/buildkit-cache-dance@6f699a72a59e4252f05a7435430009b77e25fe06 # v3.3.1
         with:
-          cache-source: go-build-cache
+          cache-map: |
+            {
+              "go-build-cache/apk": "/var/cache/apk",
+              "go-build-cache/pkg": "/go/pkg/mod",
+              "go-build-cache/build": "/root/.cache/go-build"
+            }
 
       # Build and push Docker image with Buildx (don't push on PR)
       # https://github.com/docker/build-push-action

.github/workflows/docs-check.yml

@@ -16,6 +16,16 @@ jobs:
     - name: Checkout code
       uses: actions/checkout@v6
 
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: "20"
+        cache: "npm"
+        cache-dependency-path: ui/package-lock.json
+
+    - name: Build UI
+      run: script/build-ui
+
     - name: Set up Go
       uses: actions/setup-go@v6
       with:

.github/workflows/go.yml

@@ -25,6 +25,17 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v6
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: ui/package-lock.json
+
+      - name: Build UI
+        shell: bash
+        run: script/build-ui
+
       - name: Set up Go
         uses: actions/setup-go@v6
         with:
@@ -34,6 +45,7 @@ jobs:
         run: go mod tidy -diff
 
       - name: Run unit tests
+        shell: bash
         run: script/test
 
       - name: Build

.github/workflows/goreleaser.yml

@@ -16,6 +16,16 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v6
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: ui/package-lock.json
+
+      - name: Build UI
+        run: script/build-ui
+
       - name: Set up Go
         uses: actions/setup-go@v6
         with:

.github/workflows/license-check.yml

@@ -32,6 +32,16 @@ jobs:
           GH_TOKEN: ${{ github.token }}
         run: gh pr checkout ${{ github.event.pull_request.number }}
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: ui/package-lock.json
+
+      - name: Build UI
+        run: script/build-ui
+
       - name: Set up Go
         uses: actions/setup-go@v6
         with:

.github/workflows/lint.yml

@@ -14,10 +14,18 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
+      - uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: ui/package-lock.json
+      - name: Build UI
+        run: script/build-ui
       - uses: actions/setup-go@v6
         with:
-          go-version: stable
+          go-version: '1.25'
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v9
         with:
-          version: v2.5
+          # sync with script/lint
+          version: v2.9

.github/workflows/mcp-diff.yml

@@ -19,6 +19,14 @@ jobs:
         with:
           fetch-depth: 0
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Build UI
+        run: script/build-ui
+
       - name: Run MCP Server Diff
         uses: SamMorrowDrums/mcp-server-diff@v2.3.5
         with:

.gitignore

@@ -23,3 +23,12 @@ e2e.test
 
 .history
 conformance-report/
+
+# UI build artifacts
+ui/dist/
+ui/node_modules/
+
+# Embedded UI assets (built from ui/)
+pkg/github/ui_dist/*
+!pkg/github/ui_dist/.gitkeep
+!pkg/github/ui_dist/.placeholder.html

.golangci.yml

@@ -9,12 +9,14 @@ linters:
     - gosec
     - makezero
     - misspell
+    - modernize
     - nakedret
     - revive
     - errcheck
     - staticcheck
     - govet
     - ineffassign
+    - intrange
     - unused
   exclusions:
     generated: lax
@@ -27,6 +29,11 @@ linters:
       - third_party$
       - builtin$
       - examples$
+      - internal/githubv4mock
+    rules:
+      - linters:
+          - revive
+        text: "var-naming: avoid package names that conflict with Go standard library package names"
   settings:
     staticcheck:
       checks: