Skip to content

Commit 7cb947d

Browse files
Fix nil metrics in server.go by passing metrics.NewNoopMetrics() to NewExporters
Agent-Logs-Url: https://github.com/github/github-mcp-server/sessions/53221b0b-abb4-4138-a147-3ce9e13b379a Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
1 parent e41a909 commit 7cb947d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

pkg/http/server.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"github.com/github/github-mcp-server/pkg/inventory"
1919
"github.com/github/github-mcp-server/pkg/lockdown"
2020
"github.com/github/github-mcp-server/pkg/observability"
21+
"github.com/github/github-mcp-server/pkg/observability/metrics"
2122
"github.com/github/github-mcp-server/pkg/scopes"
2223
"github.com/github/github-mcp-server/pkg/translations"
2324
"github.com/github/github-mcp-server/pkg/utils"
@@ -107,7 +108,7 @@ func RunHTTPServer(cfg ServerConfig) error {
107108

108109
featureChecker := createHTTPFeatureChecker()
109110

110-
obs, err := observability.NewExporters(logger, nil)
111+
obs, err := observability.NewExporters(logger, metrics.NewNoopMetrics())
111112
if err != nil {
112113
return fmt.Errorf("failed to create observability exporters: %w", err)
113114
}

0 commit comments

Comments
 (0)