Skip to content

Commit 97e9aa2

Browse files
committed
fix: use ENTRYPOINT and CMD for proper argument handling
- Change from CMD to ENTRYPOINT + CMD pattern for better Docker practices - ENTRYPOINT sets the executable that always runs - CMD provides default arguments that can be overridden - This allows container runtimes to properly append additional arguments - Fixes issues with argument passing in container orchestration tools Before: CMD ["./github-mcp-server", "stdio"] After: ENTRYPOINT ["./github-mcp-server"] + CMD ["stdio"]
1 parent 023f59d commit 97e9aa2

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Dockerfile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,7 @@ FROM gcr.io/distroless/base-debian12
2222
WORKDIR /server
2323
# Copy the binary from the build stage
2424
COPY --from=build /bin/github-mcp-server .
25-
# Command to run the server
26-
CMD ["./github-mcp-server", "stdio"]
25+
# Set the entrypoint to the server binary
26+
ENTRYPOINT ["./github-mcp-server"]
27+
# Default command arguments
28+
CMD ["stdio"]

0 commit comments

Comments
 (0)