Skip to content

Commit e41a909

Browse files
Fix BaseDeps.Logger and BaseDeps.Metrics to return safe defaults when Obsv is nil
Agent-Logs-Url: https://github.com/github/github-mcp-server/sessions/53221b0b-abb4-4138-a147-3ce9e13b379a Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
1 parent 2cc7300 commit e41a909

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/github/dependencies.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,15 +189,15 @@ func (d BaseDeps) GetContentWindowSize() int { return d.ContentWindowSize }
189189
// Logger implements ToolDependencies.
190190
func (d BaseDeps) Logger(_ context.Context) *slog.Logger {
191191
if d.Obsv == nil {
192-
return nil
192+
return slog.New(slog.DiscardHandler)
193193
}
194194
return d.Obsv.Logger()
195195
}
196196

197197
// Metrics implements ToolDependencies.
198198
func (d BaseDeps) Metrics(ctx context.Context) metrics.Metrics {
199199
if d.Obsv == nil {
200-
return nil
200+
return metrics.NewNoopMetrics()
201201
}
202202
return d.Obsv.Metrics(ctx)
203203
}

0 commit comments

Comments
 (0)