Update README.md to remove mcp key on .vscode/mcp.json example#186
Merged
williammartin merged 2 commits intomainfrom Apr 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README.md to remove the non-required "mcp" key from the VS Code configuration example so that it works across all versions of VS Code.
- Removed the "mcp" key block from the JSON code snippet.
- Updated the configuration example to reflect the current VS Code requirements.
fuentesjr
changed the title
SamMorrowDrums
added
the
documentation
The vscode configuration example in the README.md does not work with my version of vscode. Since it's also not required, this change removes it so that it works in all versions of vscode. Version: ``` Version: 1.99.1 (Universal) Commit: 7c6fdfb0b8f2f675eb0b47f3d95eeca78962565b Date: 2025-04-04T15:58:59.624Z (4 days ago) Electron: 34.3.2 ElectronBuildId: 11161073 Chromium: 132.0.6834.210 Node.js: 20.18.3 V8: 13.2.152.41-electron.0 OS: Darwin x64 24.3.0 ```
williammartin
force-pushed
the
fuentesjr/remove-mcp-key-from-vscode-mcp-config
branch
from
dd6e884 to
d858f11
Compare
williammartin
approved these changes
Apr 23, 2025
Collaborator
williammartin
left a comment
williammartin
left a comment
There was a problem hiding this comment.
Much better thanks.
williammartin
deleted the
fuentesjr/remove-mcp-key-from-vscode-mcp-config
branch
DaleSeo
pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
* mapbox-mcp-devkit-server * update example for access token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.vscode/mcp.jsonconfiguration example in the README.md does not appear to work with the snippet provided. There is a note that indicates that the mcp key is not needed. More specifically, the mcp key needs to be removed for the.vscode/mcp.jsonconfiguration to work. To make things simpler and easier to get started, we provide two example snippets to get started depending on which settings file is used.Before:
After:
Version: