feat: Add support for Git tag operations#345
Merged
SamMorrowDrums merged 3 commits intogithub:mainfrom Apr 30, 2025
Merged
Conversation
Contributor
Author
Collaborator
williammartin
left a comment
williammartin
left a comment
There was a problem hiding this comment.
New e2e test passes.
➜ github-mcp-server git:(tags) GITHUB_MCP_SERVER_E2E_TOKEN=$(gh auth token) go test -v -count=1 --run "TestTags" --tags e2e ./e2e
=== RUN TestTags
e2e_test.go:45: Building Docker image for e2e tests...
e2e_test.go:118: Starting Stdio MCP client...
e2e_test.go:219: Getting current user...
e2e_test.go:248: Creating repository williammartin/github-mcp-server-e2e-TestTags-1746011927745...
e2e_test.go:265: Creating tag williammartin/github-mcp-server-e2e-TestTags-1746011927745:v0.0.1...
e2e_test.go:295: Listing tags for williammartin/github-mcp-server-e2e-TestTags-1746011927745...
e2e_test.go:328: Getting tag williammartin/github-mcp-server-e2e-TestTags-1746011927745:v0.0.1...
e2e_test.go:257: Deleting repository williammartin/github-mcp-server-e2e-TestTags-1746011927745...
--- PASS: TestTags (56.03s)
PASS
ok github.com/github/github-mcp-server/e2e 56.424s
juruen
previously approved these changes
Apr 30, 2025
Collaborator
juruen
left a comment
juruen
left a comment
There was a problem hiding this comment.
LGTM! 🚀
I'm pretty happy to see the progress in making our tests more thorough!
SamMorrowDrums
previously approved these changes
Apr 30, 2025
Collaborator
There was a problem hiding this comment.
Very nice work. A couple of notes on being explicit that this exposes the concept of git tags, but I am certain it would have worked well either way. I just want to make sure for operations using the returned tags the fact they are git tags is always obvious to the model.
|
|
||
| // expectPath is a helper function to create a partial mock that expects a | ||
| // request with the given path, with the ability to chain a response handler. | ||
| func expectPath(t *testing.T, expectedPath string) *partialMock { |
Collaborator
There was a problem hiding this comment.
I like expect path. I think it will catch both errors matching args into API requests and protect from regressions also.
GitHub API is very stable and I don't expect much maintenance will be required.
Add git tag functionality including: - List repository tags - Get tag details - Support for tag-based content access This enables basic read-only tag management through the MCP server API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add git tag functionality, including:
- List repository tags
- Get tag details
- Support for tag-based content access
This enables basic read-only tag management through the MCP server API.
Closes: #344
