Ensure toolsets are configurable via env var#348
Merged
williammartin merged 5 commits intomainfrom Apr 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes toolsets configurable via an environment variable by refactoring the e2e test setup and updating the main server code to correctly unmarshal toolset configurations. Key changes include:
- Refactoring e2e tests to use sync.Once for token retrieval and Docker image building, along with introducing a ClientOpts mechanism to pass environment variables.
- Adding a new TestToolsets to validate toolset configuration via the environment variable.
- Updating the main command to unmarshal the "toolsets" configuration from the environment using viper.UnmarshalKey.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/e2e_test.go | Refactored test setup and added toolset configuration test using new client options. |
| cmd/github-mcp-server/main.go | Modified toolset configuration handling to support comma-separated values via environment vars. |
SamMorrowDrums
approved these changes
Apr 25, 2025
Collaborator
SamMorrowDrums
left a comment
SamMorrowDrums
left a comment
There was a problem hiding this comment.
Really neat PR. Loving the tests.
williammartin
deleted the
307-toolset-does-not-exists-using-github_toolsets
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #307
Reviewer Notes
You can run the e2e tests and see a failure by adjusting
GITHUB_TOOLSETSand running: