feat: upgrade golangci-lint to v2#386
Conversation
Use the latest version of `golangci-lint` and fix the CI workflow.
radar07
changed the title
| - govet | ||
| - errcheck | ||
| - staticcheck | ||
| - gofmt |
| assert-nothing-changed go fmt ./... | ||
| assert-nothing-changed go mod tidy | ||
|
|
||
| bin/golangci-lint run --out-format=colored-line-number --timeout=3m || STATUS=$? |
There was a problem hiding this comment.
What's the replacement, if any, for --out-format=colored-line-number?
There was a problem hiding this comment.
colored-line-number has been enabled by default.
I suppose the --out-format has been removed.
|
|
||
| formatters: | ||
| enable: | ||
| - gofmt |
There was a problem hiding this comment.
@radar07 I removed gci and golines. I like them but they aren't included in most people's workflows and the errors can be opaque for example:
internal/ghmcp/server.go:17:1: File is not properly formatted (gci)
^
Totally unclear how to fix unless you understand what gci is. Not worth the hassle.
| - '-QF1008' # Allow embedded structs to be referenced by field | ||
| - '-ST1000' # Do not require package comments | ||
| revive: | ||
| rules: |
There was a problem hiding this comment.
Turned off a few code comment rules. Not that they are wrong, but because we should turn them on intentionally rather than just because we're doing an upgrade.
|
Bypassing last pusher review requirement because my changes were minor to bring the linters into alignment with existing |
Co-authored-by: William Martin <williammartin@github.com>
2 participants
Use the latest version of
golangci-lintand fix the CI workflow.Closes: #378