Alter the description of get-me to reduce redundant repeat calls#411
Merged
SamMorrowDrums merged 3 commits intomainfrom May 19, 2025
Merged
Alter the description of get-me to reduce redundant repeat calls#411SamMorrowDrums merged 3 commits intomainfrom
SamMorrowDrums merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the description of the get_me tool to note that its output is static unless the user updates their profile, discouraging redundant repeated calls.
- Enhanced tool description in
GetMeto mention caching behavior - Clarified that the response won’t change unless the profile is updated
| func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (tool mcp.Tool, handler server.ToolHandlerFunc) { | ||
| return mcp.NewTool("get_me", | ||
| mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request include \"me\", \"my\"...")), | ||
| mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request include \"me\", \"my\"... the output will not change unless the user changes their profile, so only call this once.")), |
There was a problem hiding this comment.
[nitpick] Style: replace the ellipsis and run-on sentence with two clear sentences. For example: "... "my". The output remains unchanged unless the user updates their profile, so a single call is sufficient."
Suggested change
| mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request include \"me\", \"my\"... the output will not change unless the user changes their profile, so only call this once.")), | |
| mcp.WithDescription(t("TOOL_GET_ME_DESCRIPTION", "Get details of the authenticated GitHub user. Use this when a request includes \"me\" or \"my\". The output will not change unless the user updates their profile. Therefore, only call this once.")), |
williammartin
previously approved these changes
May 19, 2025
Collaborator
williammartin
left a comment
williammartin
left a comment
There was a problem hiding this comment.
LGTM with copilots suggestions (or at least, includes typo).
williammartin
approved these changes
May 19, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
williammartin
force-pushed
the
get-me-description
branch
from
b90eafe to
eefc39a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of times the get-me tool is called multiple times in a row, which is redundant. This attempts to address this, by explaining to the model it will not be updated normally.