Merged
Conversation
f907b13 to
251a447
Compare
SamMorrowDrums
approved these changes
Mar 28, 2025
Collaborator
SamMorrowDrums
left a comment
There was a problem hiding this comment.
I think that's great work to get started. I think lettings these evolve and not standing in the way is the best way to get this going, so this is a bit of a LGTM review, but I did glance over all the lines 😅
Collaborator
Author
|
Well, the test currently fails so I don't want to merge it but thanks 😬 I'll probably put these behind a build tag. |
Collaborator
Yeah I figured you'd fix it first, but whether you do that now, or in multiple PRs to me is secondary. |
dbe5bd1 to
58b3a27
Compare
58b3a27 to
7a8e2db
Compare
williammartin
commented
Mar 28, 2025
| } | ||
| } | ||
|
|
||
| func diffNonNilFields(a, b interface{}, path string) string { |
Collaborator
Author
There was a problem hiding this comment.
Don't look too closely.
Collaborator
Author
There was a problem hiding this comment.
Avert your eyes.
Collaborator
Author
There was a problem hiding this comment.
Is call of Cthulhu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given you have both
github/github-mcp-serverandmcp/githubimages available locally.Requires
-tags conformanceto avoid pollutinggo test ./...with failures due to missing deps.A failure looks like:
Notes
Lots of quality of life improvements to be had, lots of shortcuts taken, lots lots lots.
I tried to use testcontainers first to get some lifecycle management out of the box but it turns out they don't provide any way to get a handle to stdin.
I know the
mark3labsmodule provides types for us, and probably we'll end up using them, but I was exploring the schema ground up as I was writing this, so it was exploratory for me too.