Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a filter to ensure only issues are returned by SearchIssues and provides an end-to-end test for listing issues.
- Append
is:issueto the search query if it's not already present - Introduce
TestListIssuesE2E test to validate issue creation and retrieval
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/github/issues.go | Insert is:issue into the query string when missing |
| e2e/e2e_test.go | Add TestListIssues function to cover list_issues |
Comments suppressed due to low confidence (1)
pkg/github/issues.go:195
- Consider adding a unit test for
SearchIssuesto verify that it appendsis:issuewhen missing and does not duplicate the filter if it's already present.
if !strings.Contains(query, "is:issue") {
e2e/e2e_test.go
Outdated
| } | ||
|
|
||
| t.Logf("Creating repository %s/%s...", currentOwner, repoName) | ||
| _, err = mcpClient.CallTool(ctx, createRepoRequest) |
There was a problem hiding this comment.
The test ignores the response from create_repository but then asserts on resp.IsError, which is stale. Change this line to resp, err = mcpClient.CallTool(...) so you capture the actual tool response before asserting.
Suggested change
| _, err = mcpClient.CallTool(ctx, createRepoRequest) | |
| resp, err := mcpClient.CallTool(ctx, createRepoRequest) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
SamMorrowDrums
left a comment
SamMorrowDrums
left a comment
There was a problem hiding this comment.
I feel like we cannot do this atomically without the commensurate pull request version.
Can you add the pull request tool as a PR with this as base branch maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
is:issueparameter toSearchIssuesquery.Closes: #462