Skip to content

Use matrix with parametrized ci.yaml for future os upgrades#185

Open
mpenny-github wants to merge 3 commits into
masterfrom
paramaterize_ci
Open

Use matrix with parametrized ci.yaml for future os upgrades#185
mpenny-github wants to merge 3 commits into
masterfrom
paramaterize_ci

Conversation

@mpenny-github
Copy link
Copy Markdown
Contributor

This is the first PR in a series to add support for running glb-director on ubuntu noble. This PR uses the matrix option in the ci action to build over a list of operating systems. The current list is only the existing focal distro. Noble will be added in a future commit.

It also updates the script/helpers/folding.sh to use github action style folding macros.

Copilot AI review requested due to automatic review settings May 19, 2026 15:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the CI pipeline for future Ubuntu distro upgrades by switching the GitHub Actions workflow to a matrix-driven build (currently only focal) and consolidating the package build script to accept a distro parameter. It also updates log folding to use GitHub Actions’ native grouping commands.

Changes:

  • Convert .github/workflows/ci.yml to a matrix.distro strategy and parameterize artifact naming per distro.
  • Replace the focal-specific package build script with a single script/cibuild-create-packages entrypoint that accepts a distro argument (defaulting to focal).
  • Update script/helpers/folding.sh to emit ::group:: / ::endgroup:: markers for GitHub Actions log folding.
Show a summary per file
File Description
script/helpers/folding.sh Switches folding markers to GitHub Actions grouping commands.
script/cibuild-create-packages-focal Removes the focal-only package build wrapper script.
script/cibuild-create-packages Adds a DISTRO argument (default focal) and uses it to select the Dockerfile/image tag.
.github/workflows/ci.yml Introduces a distro matrix and distro-specific tar/artifact names.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 2

Comment thread script/cibuild-create-packages
Comment thread .github/workflows/ci.yml
mpenny-github and others added 2 commits May 19, 2026 12:02
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…run on arm64 hosts. Pin to a specific focal version to harden security
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants