Use matrix with parametrized ci.yaml for future os upgrades#185
Open
mpenny-github wants to merge 3 commits into
Open
Use matrix with parametrized ci.yaml for future os upgrades#185mpenny-github wants to merge 3 commits into
mpenny-github wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the CI pipeline for future Ubuntu distro upgrades by switching the GitHub Actions workflow to a matrix-driven build (currently only focal) and consolidating the package build script to accept a distro parameter. It also updates log folding to use GitHub Actions’ native grouping commands.
Changes:
- Convert
.github/workflows/ci.ymlto amatrix.distrostrategy and parameterize artifact naming per distro. - Replace the focal-specific package build script with a single
script/cibuild-create-packagesentrypoint that accepts a distro argument (defaulting tofocal). - Update
script/helpers/folding.shto emit::group::/::endgroup::markers for GitHub Actions log folding.
Show a summary per file
| File | Description |
|---|---|
script/helpers/folding.sh |
Switches folding markers to GitHub Actions grouping commands. |
script/cibuild-create-packages-focal |
Removes the focal-only package build wrapper script. |
script/cibuild-create-packages |
Adds a DISTRO argument (default focal) and uses it to select the Dockerfile/image tag. |
.github/workflows/ci.yml |
Introduces a distro matrix and distro-specific tar/artifact names. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…run on arm64 hosts. Pin to a specific focal version to harden security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series to add support for running glb-director on ubuntu noble. This PR uses the matrix option in the ci action to build over a list of operating systems. The current list is only the existing focal distro. Noble will be added in a future commit.
It also updates the script/helpers/folding.sh to use github action style folding macros.