Skip to content

Commit a647442

Browse files
zkoppertCopilot
andcommitted
fix: use pessimistic nokogiri version constraints
Address review feedback: replace open-ended >= 1.19.2 with pessimistic constraints to prevent a hypothetical nokogiri 2.0 from being pulled in. - gemspec: ~> 1.19.2 (allows 1.19.x patches, caps at < 1.20) - Gemfile: ~> 1.19 (allows 1.19.x and 1.20.x, caps at < 2.0) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 3ff1a26 commit a647442

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ gem "twitter-text", "~> 1.14"
1515
gem "asciidoctor", "~> 2.0.26"
1616
gem "rake"
1717
gem "rexml"
18-
gem "nokogiri", ">= 1.19.2"
18+
gem "nokogiri", "~> 1.19"

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ DEPENDENCIES
126126
html-pipeline (~> 1.0)
127127
kramdown
128128
minitest (~> 5.4, >= 5.4.3)
129-
nokogiri (>= 1.19.2)
129+
nokogiri (~> 1.19)
130130
nokogiri-diff (~> 0.3.0)
131131
org-ruby (= 0.9.12)
132132
rake

github-markup.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
2525
s.add_development_dependency 'minitest', '~> 5.4', '>= 5.4.3'
2626
s.add_development_dependency 'html-pipeline', '~> 1.0'
2727
s.add_development_dependency 'sanitize', '>= 4.6.3'
28-
s.add_development_dependency 'nokogiri', '>= 1.19.2'
28+
s.add_development_dependency 'nokogiri', '~> 1.19.2'
2929
s.add_development_dependency 'nokogiri-diff', '~> 0.3.0'
3030
s.add_development_dependency "github-linguist", ">= 7.1.3"
3131
end

0 commit comments

Comments
 (0)