-
Notifications
You must be signed in to change notification settings - Fork 212
Expand file tree
/
Copy pathsettings.test.js
More file actions
552 lines (465 loc) · 17.2 KB
/
Copy pathsettings.test.js
File metadata and controls
552 lines (465 loc) · 17.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
/* eslint-disable no-undef */
class Octokit {}
const Settings = require('../../../lib/settings')
const yaml = require('js-yaml')
// jest.mock('../../../lib/settings', () => {
// const OriginalSettings = jest.requireActual('../../../lib/settings')
// //const orginalSettingsInstance = new OriginalSettings(false, stubContext, mockRepo, config, mockRef, mockSubOrg)
// return OriginalSettings
// })
describe('Settings Tests', () => {
let stubContext
let mockRepo
let stubConfig
let mockRef
let mockSubOrg
let subOrgConfig
function createSettings(config) {
const settings = new Settings(false, stubContext, mockRepo, config, mockRef, mockSubOrg)
return settings;
}
beforeEach(() => {
const mockOctokit = jest.mocked(Octokit)
const content = Buffer.from(`
suborgrepos:
- new-repo
#- test*
#- secret*
suborgteams:
- core
suborgproperties:
- EDP: true
- do_no_delete: true
teams:
- name: core
permission: bypass
- name: docss
permission: pull
- name: docs
permission: pull
validator:
pattern: '[a-zA-Z0-9_-]+_[a-zA-Z0-9_-]+.*'
repository:
# A comma-separated list of topics to set on the repository
topics:
- frontend
`).toString('base64');
mockOctokit.rest = {
repos: {
getContent: jest.fn().mockResolvedValue({ data: { content } })
}
}
mockOctokit.request = {
endpoint: jest.fn().mockReturnValue({})
}
mockOctokit.paginate = jest.fn().mockResolvedValue([])
stubContext = {
payload: {
installation: {
id: 123
}
},
octokit: mockOctokit,
log: {
debug: jest.fn((msg) => {
console.log(msg)
}),
info: jest.fn((msg) => {
console.log(msg)
}),
error: jest.fn((msg) => {
console.log(msg)
})
}
}
mockRepo = { owner: 'test', repo: 'test-repo' }
mockRef = 'main'
mockSubOrg = 'frontend'
})
describe('restrictedRepos', () => {
describe('restrictedRepos not defined', () => {
beforeEach(() => {
stubConfig = {
restrictedRepos: {
}
}
})
it('Allow repositories being configured', () => {
settings = createSettings(stubConfig)
expect(settings.isRestricted('my-repo')).toEqual(false)
expect(settings.isRestricted('another-repo')).toEqual(false)
})
it('Do not allow default excluded repositories being configured', () => {
settings = createSettings(stubConfig)
expect(settings.isRestricted('.github')).toEqual(false)
expect(settings.isRestricted('safe-settings')).toEqual(false)
expect(settings.isRestricted('admin')).toEqual(false)
})
})
describe('restrictedRepos.exclude defined', () => {
beforeEach(() => {
stubConfig = {
restrictedRepos: {
exclude: ['foo', '*-test', 'personal-*']
}
}
})
it('Skipping excluded repository from being configured', () => {
settings = createSettings(stubConfig)
expect(settings.isRestricted('foo')).toEqual(true)
})
it('Skipping excluded repositories matching regex in restrictedRepos.exclude', () => {
settings = createSettings(stubConfig)
expect(settings.isRestricted('my-repo-test')).toEqual(true)
expect(settings.isRestricted('personal-repo')).toEqual(true)
})
it('Allowing repositories not matching regex in restrictedRepos.exclude', () => {
settings = createSettings(stubConfig)
expect(settings.isRestricted('my-repo-test-data')).toEqual(false)
expect(settings.isRestricted('personalization-repo')).toEqual(false)
})
})
describe('restrictedRepos.include defined', () => {
beforeEach(() => {
stubConfig = {
restrictedRepos: {
include: ['foo', '*-test', 'personal-*']
}
}
})
it('Allowing repository from being configured', () => {
settings = createSettings(stubConfig)
expect(settings.isRestricted('foo')).toEqual(false)
})
it('Allowing repositories matching regex in restrictedRepos.include', () => {
settings = createSettings(stubConfig)
expect(settings.isRestricted('my-repo-test')).toEqual(false)
expect(settings.isRestricted('personal-repo')).toEqual(false)
})
it('Skipping repositories not matching regex in restrictedRepos.include', () => {
settings = createSettings(stubConfig)
expect(settings.isRestricted('my-repo-test-data')).toEqual(true)
expect(settings.isRestricted('personalization-repo')).toEqual(true)
})
})
describe('restrictedRepos not defined', () => {
it('Throws TypeError if restrictedRepos not defined', () => {
stubConfig = {}
settings = createSettings(stubConfig)
expect(() => settings.isRestricted('my-repo')).toThrow('Cannot read properties of undefined (reading \'include\')')
})
it('Throws TypeError if restrictedRepos is null', () => {
stubConfig = {
restrictedRepos: null
}
settings = createSettings(stubConfig)
expect(() => settings.isRestricted('my-repo')).toThrow('Cannot read properties of null (reading \'include\')')
})
it('Allowing all repositories if restrictedRepos is empty', () => {
stubConfig = {
restrictedRepos: []
}
settings = createSettings(stubConfig)
expect(settings.isRestricted('my-repo')).toEqual(false)
})
})
}) // restrictedRepos
describe('getRepoOverrideConfig', () => {
describe('repository defined in a file using the .yaml extension', () => {
beforeEach(() => {
stubConfig = {
repoConfigs: {
'repository.yaml': { repository: { name: 'repository', config: 'config1' } }
}
}
})
it('Picks up a repository defined in file using the .yaml extension', () => {
settings = createSettings(stubConfig)
settings.repoConfigs = stubConfig.repoConfigs
const repoConfig = settings.getRepoOverrideConfig('repository')
expect(typeof repoConfig).toBe('object')
expect(repoConfig).not.toBeNull()
expect(Object.keys(repoConfig).length).toBeGreaterThan(0)
})
})
describe('repository defined in a file using the .yml extension', () => {
beforeEach(() => {
stubConfig = {
repoConfigs: {
'repository.yml': { repository: { name: 'repository', config: 'config1' } }
}
}
})
it('Picks up a repository defined in file using the .yml extension', () => {
settings = createSettings(stubConfig)
settings.repoConfigs = stubConfig.repoConfigs
const repoConfig = settings.getRepoOverrideConfig('repository')
expect(typeof repoConfig).toBe('object')
expect(repoConfig).not.toBeNull()
expect(Object.keys(repoConfig).length).toBeGreaterThan(0)
})
})
}) // repoOverrideConfig
describe('loadConfigs', () => {
describe('load suborg configs', () => {
beforeEach(() => {
stubConfig = {
restrictedRepos: {
}
}
subOrgConfig = yaml.load(`
suborgrepos:
- new-repo
suborgproperties:
- EDP: true
- do_no_delete: true
teams:
- name: core
permission: bypass
- name: docss
permission: pull
- name: docs
permission: pull
validator:
pattern: '[a-zA-Z0-9_-]+_[a-zA-Z0-9_-]+.*'
repository:
# A comma-separated list of topics to set on the repository
topics:
- frontend
`)
})
it("Should load configMap for suborgs'", async () => {
//mockSubOrg = jest.fn().mockReturnValue(['suborg1', 'suborg2'])
mockSubOrg = undefined
settings = createSettings(stubConfig)
jest.spyOn(settings, 'loadConfigMap').mockImplementation(() => [{ name: "frontend", path: ".github/suborgs/frontend.yml" }])
jest.spyOn(settings, 'loadYaml').mockImplementation(() => subOrgConfig)
jest.spyOn(settings, 'getReposForTeam').mockImplementation(() => [{ name: 'repo-test' }])
jest.spyOn(settings, 'getSubOrgRepositories').mockImplementation(() => [{ repository_name: 'repo-for-property' }])
const subOrgConfigs = await settings.getSubOrgConfigs()
expect(settings.loadConfigMap).toHaveBeenCalledTimes(1)
// Get own properties of subOrgConfigs
const ownProperties = Object.getOwnPropertyNames(subOrgConfigs);
expect(ownProperties.length).toEqual(3)
})
it("Should throw an error when a repo is found in multiple suborgs configs'", async () => {
//mockSubOrg = jest.fn().mockReturnValue(['suborg1', 'suborg2'])
mockSubOrg = undefined
settings = createSettings(stubConfig)
jest.spyOn(settings, 'loadConfigMap').mockImplementation(() => [{ name: "frontend", path: ".github/suborgs/frontend.yml" }, { name: "backend", path: ".github/suborgs/backend.yml" }])
jest.spyOn(settings, 'loadYaml').mockImplementation(() => subOrgConfig)
jest.spyOn(settings, 'getReposForTeam').mockImplementation(() => [{ name: 'repo-test' }])
jest.spyOn(settings, 'getSubOrgRepositories').mockImplementation(() => [{ repository_name: 'repo-for-property' }])
expect(async () => await settings.getSubOrgConfigs()).rejects.toThrow('Multiple suborg configs for new-repo in .github/suborgs/backend.yml and .github/suborgs/frontend.yml')
// try {
// await settings.getSubOrgConfigs()
// } catch (e) {
// console.log(e)
// }
})
})
}) // loadConfigs
describe('loadYaml', () => {
let settings;
beforeEach(() => {
Settings.fileCache = {};
stubContext = {
octokit: {
rest: {
repos: {
getContent: jest.fn()
}
},
request: jest.fn(),
paginate: jest.fn()
},
log: {
debug: jest.fn(),
info: jest.fn(),
error: jest.fn()
},
payload: {
installation: {
id: 123
}
}
};
settings = createSettings({});
});
it('should return parsed YAML content when file is fetched successfully', async () => {
// Given
const filePath = 'path/to/file.yml';
const content = Buffer.from('key: value').toString('base64');
jest.spyOn(settings.github.rest.repos, 'getContent').mockResolvedValue({
data: { content },
headers: { etag: 'etag123' }
});
// When
const result = await settings.loadYaml(filePath);
// Then
expect(result).toEqual({ key: 'value' });
expect(Settings.fileCache[`${mockRepo.owner}/${filePath}`]).toEqual({
etag: 'etag123',
data: { content }
});
});
it('should return cached content when file has not changed (304 response)', async () => {
// Given
const filePath = 'path/to/file.yml';
const content = Buffer.from('key: value').toString('base64');
Settings.fileCache[`${mockRepo.owner}/${filePath}`] = { etag: 'etag123', data: { content } };
jest.spyOn(settings.github.rest.repos, 'getContent').mockRejectedValue({ status: 304 });
// When
const result = await settings.loadYaml(filePath);
// Then
expect(result).toEqual({ key: 'value' });
expect(settings.github.rest.repos.getContent).toHaveBeenCalledWith(
expect.objectContaining({ headers: { 'If-None-Match': 'etag123' } })
);
});
it('should not return cached content when the cache is for another org', async () => {
// Given
const filePath = 'path/to/file.yml';
const content = Buffer.from('key: value').toString('base64');
const wrongContent = Buffer.from('wrong: content').toString('base64');
Settings.fileCache['another-org/path/to/file.yml'] = { etag: 'etag123', data: { wrongContent } };
jest.spyOn(settings.github.rest.repos, 'getContent').mockResolvedValue({
data: { content },
headers: { etag: 'etag123' }
});
// When
const result = await settings.loadYaml(filePath);
// Then
expect(result).toEqual({ key: 'value' });
})
it('should return null when the file path is a folder', async () => {
// Given
const filePath = 'path/to/folder';
jest.spyOn(settings.github.rest.repos, 'getContent').mockResolvedValue({
data: []
});
// When
const result = await settings.loadYaml(filePath);
// Then
expect(result).toBeNull();
});
it('should return null when the file is a symlink or submodule', async () => {
// Given
const filePath = 'path/to/symlink';
jest.spyOn(settings.github.rest.repos, 'getContent').mockResolvedValue({
data: { content: null }
});
// When
const result = await settings.loadYaml(filePath);
// Then
expect(result).toBeUndefined();
});
it('should handle 404 errors gracefully and return null', async () => {
// Given
const filePath = 'path/to/nonexistent.yml';
jest.spyOn(settings.github.rest.repos, 'getContent').mockRejectedValue({ status: 404 });
// When
const result = await settings.loadYaml(filePath);
// Then
expect(result).toBeNull();
});
it('should throw an error for non-404 exceptions when not in nop mode', async () => {
// Given
const filePath = 'path/to/error.yml';
jest.spyOn(settings.github.rest.repos, 'getContent').mockRejectedValue(new Error('Unexpected error'));
// When / Then
await expect(settings.loadYaml(filePath)).rejects.toThrow('Unexpected error');
});
it('should log and append NopCommand for non-404 exceptions in nop mode', async () => {
// Given
const filePath = 'path/to/error.yml';
settings.nop = true;
jest.spyOn(settings.github.rest.repos, 'getContent').mockRejectedValue(new Error('Unexpected error'));
jest.spyOn(settings, 'appendToResults');
// When
const result = await settings.loadYaml(filePath);
// Then
expect(result).toBeUndefined();
expect(settings.appendToResults).toHaveBeenCalledWith(
expect.arrayContaining([
expect.objectContaining({
type: 'ERROR',
action: expect.objectContaining({
msg: expect.stringContaining('Unexpected error')
})
})
])
);
});
});
describe('updateRepos - archived repo skipping', () => {
const Archive = require('../../../lib/plugins/archive')
let settings
let mockRepoSync
let originalRepoPlugin
beforeEach(() => {
// Preserve the original RepoPlugin so it can be restored after each test
originalRepoPlugin = Settings.PLUGINS.repository
// Replace RepoPlugin with a mock constructor whose sync() we can assert on
mockRepoSync = jest.fn().mockResolvedValue([])
Settings.PLUGINS.repository = jest.fn().mockImplementation(() => ({
sync: mockRepoSync
}))
// Build a Settings instance that will enter the `if (repoConfig)` branch:
// config.repository must be defined so repoConfig is truthy
settings = new Settings(
false,
stubContext,
{ owner: 'test-org', repo: 'test-repo' },
{ repository: { name: 'test-repo' } },
'main'
)
// Pre-set subOrgConfigs so updateRepos() does not call the async getSubOrgConfigs()
settings.subOrgConfigs = {}
// Pre-set repoConfigs so getRepoOverrideConfig() does not throw on undefined
settings.repoConfigs = {}
})
afterEach(() => {
// Restore the real RepoPlugin and all prototype spies
Settings.PLUGINS.repository = originalRepoPlugin
jest.restoreAllMocks()
})
it('updateRepos when repo is already archived and not being unarchived does not call RepoPlugin sync', async () => {
// Arrange
jest.spyOn(Archive.prototype, 'getState').mockResolvedValue({
isArchived: true,
shouldArchive: false,
shouldUnarchive: false
})
// Act
await settings.updateRepos({ owner: 'test-org', repo: 'test-repo' })
// Assert
expect(mockRepoSync).not.toHaveBeenCalled()
})
it('updateRepos when repo is archived but is being unarchived calls RepoPlugin sync', async () => {
// Arrange
jest.spyOn(Archive.prototype, 'getState').mockResolvedValue({
isArchived: true,
shouldArchive: false,
shouldUnarchive: true
})
jest.spyOn(Archive.prototype, 'sync').mockResolvedValue([])
// Act
await settings.updateRepos({ owner: 'test-org', repo: 'test-repo' })
// Assert
expect(mockRepoSync).toHaveBeenCalledTimes(1)
})
it('updateRepos when repo is not archived calls RepoPlugin sync', async () => {
// Arrange
jest.spyOn(Archive.prototype, 'getState').mockResolvedValue({
isArchived: false,
shouldArchive: false,
shouldUnarchive: false
})
// Act
await settings.updateRepos({ owner: 'test-org', repo: 'test-repo' })
// Assert
expect(mockRepoSync).toHaveBeenCalledTimes(1)
})
}) // updateRepos - archived repo skipping
}) // Settings Tests