Skip to content

Commit 0d40211

Browse files
committed
Mutate variable instead of copying to new variable
1 parent 653ce38 commit 0d40211

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

src/index.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,21 @@ export function persistResumableFields(id: string, options?: PersistOptions): vo
2020
}
2121
}
2222

23-
const fields = resumables.filter(field => shouldResumeField(field)).map(field => [field.id, field.value])
23+
let fields = resumables.filter(field => shouldResumeField(field)).map(field => [field.id, field.value])
2424

2525
if (fields.length) {
2626
try {
2727
const previouslyStoredFieldsJson = sessionStorage.getItem(key)
28-
let allFields: string[][] = fields
2928

3029
if (previouslyStoredFieldsJson !== null) {
3130
const previouslyStoredFields: string[][] = JSON.parse(previouslyStoredFieldsJson)
3231
const fieldsNotReplaced: string[][] = previouslyStoredFields.filter(function (oldField) {
33-
return !allFields.some(field => field[0] === oldField[0])
32+
return !fields.some(field => field[0] === oldField[0])
3433
})
35-
allFields = allFields.concat(fieldsNotReplaced)
34+
fields = fields.concat(fieldsNotReplaced)
3635
}
3736

38-
sessionStorage.setItem(key, JSON.stringify(allFields))
37+
sessionStorage.setItem(key, JSON.stringify(fields))
3938
} catch {
4039
// Ignore browser private mode error.
4140
}

0 commit comments

Comments
 (0)