Commit e240a4e
committed
Make sure to access
In #38 we allowed callers
to pass in their own storage implementation. We accidentally leaked a `window.sessionStorage` access outside of a `try` block, though,
and this could lead to errors when users have cookies disabled or are
in private mode.
I've chosen to keep the other `try/catch` blocks to minimize changes.sessionStorage in a try block1 parent e2d3656 commit e240a4e
1 file changed
Lines changed: 18 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
19 | 27 | | |
20 | 28 | | |
21 | 29 | | |
| |||
50 | 58 | | |
51 | 59 | | |
52 | 60 | | |
53 | | - | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
54 | 70 | | |
55 | 71 | | |
56 | 72 | | |
| |||
0 commit comments