Skip to content

Commit 050dd41

Browse files
committed
Remove signing, when Password not exists
1 parent 517b060 commit 050dd41

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/build-binaries.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,9 @@ jobs:
101101
run: |
102102
GOARCH=386 go build -o "build/386/smimesign.exe" -ldflags "-X main.versionString=${{ env.GIT_VERSION }}" .
103103
- name: Sign amd64 and 386
104-
if: startsWith(github.ref, 'refs/tags/v')
104+
env:
105+
PFX_PASSWORD: ${{ secrets.PFX_PASSWORD }}
106+
if: startsWith(github.ref, 'refs/tags/v') && env.PFX_PASSWORD != ''
105107
run: |
106108
.\windows-installer\signtool.exe sign /tr http://timestamp.digicert.com /td sha256 /fd sha256 /p ${{ secrets.PFX_PASSWORD }} /f windows-installer\codesign.pfx build/amd64/smimesign.exe
107109
.\windows-installer\signtool.exe sign /tr http://timestamp.digicert.com /td sha256 /fd sha256 /p ${{ secrets.PFX_PASSWORD }} /f windows-installer\codesign.pfx build/386/smimesign.exe
@@ -110,7 +112,9 @@ jobs:
110112
run: |
111113
GIT_VERSION=${{ env.GIT_VERSION }} BARE_GIT_VERSION=${{ env.BARE_GIT_VERSION }} iscc windows-installer/inno-setup-smimesign-installer.iss
112114
- name: Sign installer
113-
if: startsWith(github.ref, 'refs/tags/v')
115+
env:
116+
PFX_PASSWORD: ${{ secrets.PFX_PASSWORD }}
117+
if: startsWith(github.ref, 'refs/tags/v') && env.PFX_PASSWORD != ''
114118
run: |
115119
.\windows-installer\signtool.exe sign /tr http://timestamp.digicert.com /td sha256 /fd sha256 /p ${{ secrets.PFX_PASSWORD }} /f windows-installer\codesign.pfx build\installer\smimesign-windows-*.exe
116120
- name: Create zips for release upload

0 commit comments

Comments
 (0)