fix: address twenty-ninth round of Copilot PR review feedback

- Fix TestCollectAllLayers docstring: reference collect_all_layers()
- Add default/unknown strategy handling in bash/PS1 composition: error
  on unrecognized strategy values instead of silently skipping
- Fix comment: .composed/ is a persistent dir, not temporary
- Fix comment: legacy fallback checks all valid strategies, not just wrap
- Cache PresetRegistry in _reconcile_skills: build presets_by_priority
  once instead of constructing registry per-command

Author: mnriem

scripts/bash/common.sh

@@ -577,6 +577,7 @@ except Exception:
                         done
                         content="$layer_content"
                         ;;
+                    *) echo "Error: unknown strategy '$strat'" >&2; return 1 ;;
                 esac
             fi
         else
@@ -596,6 +597,7 @@ except Exception:
                     done
                     content="$layer_content"
                     ;;
+                *) echo "Error: unknown strategy '$strat'" >&2; return 1 ;;
             esac
         fi
     done

scripts/powershell/common.ps1

@@ -547,6 +547,7 @@ except Exception:
                         }
                         $content = $layerContent.Replace('{CORE_TEMPLATE}', $content)
                     }
+                    default { throw "Unknown strategy: $strat" }
                 }
             }
         } else {
@@ -560,6 +561,7 @@ except Exception:
                     }
                     $content = $layerContent.Replace('{CORE_TEMPLATE}', $content)
                 }
+                default { throw "Unknown strategy: $strat" }
             }
         }
     }

src/specify_cli/presets.py

@@ -626,7 +626,7 @@ def _register_commands(
                 # Resolve composed content using the full priority stack
                 composed = resolver.resolve_content(cmd["name"], "command")
                 if composed is not None:
-                    # Write composed content to a temporary subdirectory
+                    # Write composed content to the preset's .composed directory
                     if composed_dir is None:
                         composed_dir = preset_dir / ".composed"
                         composed_dir.mkdir(parents=True, exist_ok=True)
@@ -912,6 +912,11 @@ def _reconcile_skills(self, command_names: List[str]) -> None:
         resolver = PresetResolver(self.project_root)
         skills_dir = self._get_skills_dir()
 
+        # Cache registry once to avoid repeated filesystem reads
+        presets_by_priority = list(
+            PresetRegistry(self.presets_dir).list_by_priority()
+        ) if self.presets_dir.exists() else []
+
         # Group command names by winning preset to batch _register_skills calls
         # while only registering skills for the specific commands being reconciled.
         preset_cmds: Dict[str, List[str]] = {}
@@ -931,7 +936,7 @@ def _reconcile_skills(self, command_names: List[str]) -> None:
                 if not skill_subdir.exists():
                     # Check if any preset previously registered this skill
                     was_managed = False
-                    for _pid, meta in PresetRegistry(self.presets_dir).list_by_priority():
+                    for _pid, meta in presets_by_priority:
                         if not isinstance(meta, dict):
                             continue
                         if skill_name in meta.get("registered_skills", []):
@@ -943,7 +948,7 @@ def _reconcile_skills(self, command_names: List[str]) -> None:
             top_path = layers[0]["path"]
             # Find the preset that owns the winning layer
             found_preset = False
-            for pack_id, _meta in PresetRegistry(self.presets_dir).list_by_priority():
+            for pack_id, _meta in presets_by_priority:
                 pack_dir = self.presets_dir / pack_id
                 if top_path.is_relative_to(pack_dir):
                     preset_cmds.setdefault(pack_id, []).append(cmd_name)
@@ -2584,7 +2589,7 @@ def _find_in_subdirs(base_dir: Path) -> Optional[Path]:
                     candidate = _find_in_subdirs(pack_dir)
                 if candidate:
                     # Legacy fallback: if manifest doesn't declare a strategy,
-                    # check the command file's frontmatter for strategy: wrap
+                    # check the command file's frontmatter for any valid strategy
                     if strategy == "replace" and template_type == "command":
                         try:
                             cmd_content = candidate.read_text(encoding="utf-8")

tests/test_presets.py

@@ -4202,7 +4202,7 @@ def test_resolve_content_replace_over_wrap(self, project_dir, temp_dir, valid_pa
 
 
 class TestCollectAllLayers:
-    """Test PresetResolver._collect_all_layers() method."""
+    """Test PresetResolver.collect_all_layers() method."""
 
     def test_single_core_layer(self, project_dir):
         """Test collecting layers with only core template."""