Skip to content

Commit 0ccd16a

Browse files
mnriemCopilot
andcommitted
fix: address review — derive agent folder for generic integration and remove redundant test
- Security notice now falls back to integration_parsed_options['commands_dir'] when AGENT_CONFIG folder is None (generic integration). - Remove test_agent_config_includes_kiro_cli which duplicates the assertion in test_runtime_config_uses_kiro_cli_and_removes_q. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent a7cca0b commit 0ccd16a

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

src/specify_cli/commands/init.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ def init(
584584

585585
agent_config = AGENT_CONFIG.get(selected_ai)
586586
if agent_config:
587-
agent_folder = agent_config["folder"]
587+
agent_folder = agent_config["folder"] or integration_parsed_options.get("commands_dir")
588588
if agent_folder:
589589
security_notice = Panel(
590590
f"Some agents may store credentials, auth tokens, or other identifying and private artifacts in the agent folder within your project.\n"

tests/test_agent_config_consistency.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,6 @@ def test_runtime_codex_uses_native_skills(self):
3939
assert AGENT_CONFIG["codex"]["folder"] == ".agents/"
4040
assert AGENT_CONFIG["codex"]["commands_subdir"] == "skills"
4141

42-
def test_agent_config_includes_kiro_cli(self):
43-
"""AGENT_CONFIG should include kiro-cli."""
44-
assert "kiro-cli" in AGENT_CONFIG
45-
4642
def test_devcontainer_kiro_installer_uses_pinned_checksum(self):
4743
"""Devcontainer installer should always verify Kiro installer via pinned SHA256."""
4844
post_create_text = (REPO_ROOT / ".devcontainer" / "post-create.sh").read_text(

0 commit comments

Comments
 (0)