fix(scripts): harden feature.json persistence

mnriem · Copilot · mnriem · commit 0dc5a26287bf · 2026-06-08T16:15:48.000-05:00
- Use json_escape in printf fallback when jq is unavailable (common.sh)
- Replace utf8NoBOM encoding with UTF8Encoding($false) for PowerShell
  5.1 compatibility (common.ps1)

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/scripts/bash/common.sh b/scripts/bash/common.sh
@@ -135,7 +135,7 @@ _persist_feature_json() {
     if command -v jq >/dev/null 2>&1; then
         jq -cn --arg fd "$feature_dir_value" '{feature_directory:$fd}' > "$fj"
     else
-        printf '{"feature_directory":"%s"}\n' "$feature_dir_value" > "$fj"
+        printf '{"feature_directory":"%s"}\n' "$(json_escape "$feature_dir_value")" > "$fj"
     fi
 }
 
diff --git a/scripts/powershell/common.ps1 b/scripts/powershell/common.ps1
@@ -155,7 +155,8 @@ function Save-FeatureJson {
 
     # Write feature.json
     $json = @{ feature_directory = $FeatureDirectory } | ConvertTo-Json -Compress
-    Set-Content -LiteralPath $fjPath -Value $json -Encoding utf8NoBOM
+    $utf8NoBom = New-Object System.Text.UTF8Encoding($false)
+    [System.IO.File]::WriteAllText($fjPath, $json, $utf8NoBom)
 }
 
 function Get-FeaturePathsEnv {

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ _persist_feature_json() {`
`135`	`135`	`if command -v jq >/dev/null 2>&1; then`
`136`	`136`	`jq -cn --arg fd "$feature_dir_value" '{feature_directory:$fd}' > "$fj"`
`137`	`137`	`else`
`138`		`- printf '{"feature_directory":"%s"}\n' "$feature_dir_value" > "$fj"`
	`138`	`+ printf '{"feature_directory":"%s"}\n' "$(json_escape "$feature_dir_value")" > "$fj"`
`139`	`139`	`fi`
`140`	`140`	`}`
`141`	`141`
Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,8 @@ function Save-FeatureJson {`
`155`	`155`
`156`	`156`	`# Write feature.json`
`157`	`157`	`$json = @{ feature_directory = $FeatureDirectory } \| ConvertTo-Json -Compress`
`158`		`- Set-Content -LiteralPath $fjPath -Value $json -Encoding utf8NoBOM`
	`158`	`+ $utf8NoBom = New-Object System.Text.UTF8Encoding($false)`
	`159`	`+ [System.IO.File]::WriteAllText($fjPath, $json, $utf8NoBom)`
`159`	`160`	`}`
`160`	`161`
`161`	`162`	`function Get-FeaturePathsEnv {`