fix: address second round of PR review comments

- Add type validation for provides.commands (must be list) and hooks
  (must be dict) in manifest _validate()
- Tighten malformed timestamp detection in git-common.sh to catch
  7-digit dates without trailing slug (e.g. 2026031-143022)
- Pass REPO_ROOT to has_git/Test-HasGit in create-new-feature scripts
- Fix initialize command docs: surface errors on git failures, only
  skip when git is not installed
- Fix commit command docs: 'skips with a warning' not 'silently'
- Add tests for commands:null and hooks:list rejection

Author: mnriem

extensions/git/commands/speckit.git.commit.md

@@ -43,6 +43,6 @@ auto_commit:
 
 ## Graceful Degradation
 
-- If Git is not available or not a repository: skips silently
+- If Git is not available or the current directory is not a repository: skips with a warning
 - If no config file exists: skips (disabled by default)
 - If no changes to commit: skips with a message

extensions/git/commands/speckit.git.initialize.md

@@ -42,7 +42,11 @@ On success:
 
 ## Graceful Degradation
 
-If Git is not installed or `git init` fails:
+If Git is not installed:
 - Warn the user
-- Do NOT block the rest of the workflow
+- Skip repository initialization
 - The project continues to function without Git (specs can still be created under `specs/`)
+
+If Git is installed but `git init`, `git add .`, or `git commit` fails:
+- Surface the error to the user
+- Stop this command rather than continuing with a partially initialized repository

extensions/git/scripts/bash/create-new-feature.sh

@@ -240,7 +240,7 @@ fi
 
 # Check if git is available at this repo root
 if type has_git >/dev/null 2>&1; then
-    if has_git; then
+    if has_git "$REPO_ROOT"; then
         HAS_GIT=true
     else
         HAS_GIT=false

extensions/git/scripts/bash/git-common.sh

@@ -23,8 +23,8 @@ check_feature_branch() {
         return 0
     fi
 
-    # Reject malformed timestamps (7-digit date or no trailing slug)
-    if [[ "$branch" =~ ^[0-9]{7}-[0-9]{6}- ]] || [[ "$branch" =~ ^[0-9]{8}-[0-9]{6}$ ]]; then
+    # Reject malformed timestamps (7-digit date, 8-digit date without trailing slug, or 7-digit with slug)
+    if [[ "$branch" =~ ^[0-9]{7}-[0-9]{6} ]] || [[ "$branch" =~ ^[0-9]{8}-[0-9]{6}$ ]]; then
         echo "ERROR: Not on a feature branch. Current branch: $branch" >&2
         echo "Feature branches should be named like: 001-feature-name or 20260319-143022-feature-name" >&2
         return 1

extensions/git/scripts/powershell/create-new-feature.ps1

@@ -203,7 +203,7 @@ if (Get-Command Get-RepoRoot -ErrorAction SilentlyContinue) {
 
 # Check if git is available
 if (Get-Command Test-HasGit -ErrorAction SilentlyContinue) {
-    $hasGit = Test-HasGit
+    $hasGit = Test-HasGit -RepoRoot $repoRoot
 } else {
     try {
         git -C $repoRoot rev-parse --is-inside-work-tree 2>$null | Out-Null

src/specify_cli/extensions.py

@@ -183,16 +183,28 @@ def _validate(self):
 
         # Validate provides section
         provides = self.data["provides"]
-        has_commands = "commands" in provides and provides["commands"]
-        has_hooks = bool(self.data.get("hooks"))
+        commands = provides.get("commands", [])
+        hooks = self.data.get("hooks")
+
+        if "commands" in provides and not isinstance(commands, list):
+            raise ValidationError(
+                "Invalid provides.commands: expected a list"
+            )
+        if "hooks" in self.data and not isinstance(hooks, dict):
+            raise ValidationError(
+                "Invalid hooks: expected a mapping"
+            )
+
+        has_commands = bool(commands)
+        has_hooks = bool(hooks)
 
         if not has_commands and not has_hooks:
             raise ValidationError(
                 "Extension must provide at least one command or hook"
             )
 
         # Validate commands (if present)
-        for cmd in provides.get("commands", []):
+        for cmd in commands:
             if "name" not in cmd or "file" not in cmd:
                 raise ValidationError("Command missing 'name' or 'file'")
 

tests/test_extensions.py

@@ -291,6 +291,32 @@ def test_hooks_only_extension(self, temp_dir, valid_manifest_data):
         assert len(manifest.commands) == 0
         assert len(manifest.hooks) == 1
 
+    def test_commands_null_rejected(self, temp_dir, valid_manifest_data):
+        """Test manifest with commands: null is rejected."""
+        import yaml
+
+        valid_manifest_data["provides"]["commands"] = None
+
+        manifest_path = temp_dir / "extension.yml"
+        with open(manifest_path, 'w') as f:
+            yaml.dump(valid_manifest_data, f)
+
+        with pytest.raises(ValidationError, match="Invalid provides.commands"):
+            ExtensionManifest(manifest_path)
+
+    def test_hooks_not_dict_rejected(self, temp_dir, valid_manifest_data):
+        """Test manifest with hooks as a list is rejected."""
+        import yaml
+
+        valid_manifest_data["hooks"] = ["not", "a", "dict"]
+
+        manifest_path = temp_dir / "extension.yml"
+        with open(manifest_path, 'w') as f:
+            yaml.dump(valid_manifest_data, f)
+
+        with pytest.raises(ValidationError, match="Invalid hooks"):
+            ExtensionManifest(manifest_path)
+
     def test_manifest_hash(self, extension_dir):
         """Test manifest hash calculation."""
         manifest_path = extension_dir / "extension.yml"