Commit 36019eb
authored
feat: Auto-register ai-skills for extensions whenever applicable (#1840)
* feat: Auto-register ai-skills for extensions whenever applicable
* fix: failing test
* fix: address copilot review comments – path traversal guard and use short_name in title
* fix: address remaining copilot review comments – is_file guard, skills type-validation, and exact extension ownership check on fallback rmtree
* fix: address copilot round-3 comments – align skill naming with presets.py convention, safe rmdir on fail, require SKILL.md for fallback rmtree, normalize skill_count in CLI
* fix: is_dir() guard in fast-path rmtree and fix ghost-skill assertion naming
* fix: path-traversal guard on skill_name in both rmtree paths of _unregister_extension_skills
* fix: add SKILL.md ownership check to fast-path rmtree and alias shadowed _get_skills_dir import1 parent fb152eb commit 36019eb
File tree
6 files changed
+972
-5
lines changed- extensions
- src/specify_cli
- tests
6 files changed
+972
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
295 | | - | |
| 295 | + | |
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
190 | 205 | | |
191 | 206 | | |
192 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3594 | 3594 | | |
3595 | 3595 | | |
3596 | 3596 | | |
| 3597 | + | |
| 3598 | + | |
| 3599 | + | |
| 3600 | + | |
| 3601 | + | |
| 3602 | + | |
| 3603 | + | |
| 3604 | + | |
| 3605 | + | |
3597 | 3606 | | |
3598 | 3607 | | |
3599 | 3608 | | |
| |||
3632 | 3641 | | |
3633 | 3642 | | |
3634 | 3643 | | |
3635 | | - | |
| 3644 | + | |
3636 | 3645 | | |
3637 | 3646 | | |
| 3647 | + | |
| 3648 | + | |
| 3649 | + | |
3638 | 3650 | | |
3639 | 3651 | | |
3640 | 3652 | | |
3641 | 3653 | | |
3642 | 3654 | | |
| 3655 | + | |
| 3656 | + | |
3643 | 3657 | | |
3644 | 3658 | | |
3645 | 3659 | | |
| |||
0 commit comments