fix: extract shared auth test helpers, global config isolation, align docstring

- Move _inject_github_config / make_github_auth_entry to tests/auth_helpers.py
  to eliminate duplication across test_extensions, test_presets, test_upgrade
- Move auth config isolation fixture to global conftest.py (autouse) so ALL
  tests are isolated from ~/.specify/auth.json, not just test_upgrade
- Align load_auth_config docstring with actual behavior: ValueError may be
  caught by higher-level HTTP helpers that warn and continue unauthenticated
- 1831 tests passing

Author: mnriem

src/specify_cli/authentication/config.py

@@ -51,8 +51,10 @@ def load_auth_config(
     Returns an empty list when the file does not exist — this means
     all HTTP requests will be unauthenticated (opt-in model).
 
-    Raises ``ValueError`` on schema violations so misconfigurations
-    surface immediately rather than silently degrading to no-auth.
+    Raises ``ValueError`` on schema violations.  Callers that want
+    misconfigurations to fail fast can allow this exception to
+    propagate; higher-level HTTP helpers may instead catch it,
+    warn, and continue with unauthenticated requests.
     """
     config_path = path or _default_config_path()
 

tests/auth_helpers.py

@@ -0,0 +1,21 @@
+"""Shared test helpers for authentication config injection."""
+
+from __future__ import annotations
+
+from specify_cli.authentication.config import AuthConfigEntry
+
+
+def make_github_auth_entry(token_env: str = "GH_TOKEN") -> AuthConfigEntry:
+    """Build a GitHub ``AuthConfigEntry`` for testing."""
+    return AuthConfigEntry(
+        hosts=("github.com", "api.github.com", "raw.githubusercontent.com", "codeload.github.com"),
+        provider="github",
+        auth="bearer",
+        token_env=token_env,
+    )
+
+
+def inject_github_config(monkeypatch, token_env: str = "GH_TOKEN") -> None:
+    """Inject a GitHub auth.json config entry into the auth HTTP module."""
+    from specify_cli.authentication import http as _auth_http
+    monkeypatch.setattr(_auth_http, "_config_override", [make_github_auth_entry(token_env)])

tests/conftest.py

@@ -66,3 +66,15 @@ def _has_working_bash() -> bool:
 def strip_ansi(text: str) -> str:
     """Remove ANSI escape codes from Rich-formatted CLI output."""
     return _ANSI_ESCAPE_RE.sub("", text)
+
+
+# ---------------------------------------------------------------------------
+# Auth config isolation — prevents tests from reading ~/.specify/auth.json
+# ---------------------------------------------------------------------------
+
+
+@pytest.fixture(autouse=True)
+def _isolate_auth_config(monkeypatch):
+    """Ensure no test reads the real ~/.specify/auth.json."""
+    from specify_cli.authentication import http as _auth_http
+    monkeypatch.setattr(_auth_http, "_config_override", [])

tests/test_extensions.py

@@ -2454,16 +2454,8 @@ def _make_catalog(self, temp_dir):
         return ExtensionCatalog(project_dir)
 
     def _inject_github_config(self, monkeypatch, token_env="GH_TOKEN"):
-        """Inject a GitHub auth.json config entry for testing."""
-        from specify_cli.authentication.config import AuthConfigEntry
-        import specify_cli.authentication.http as _mod
-        entry = AuthConfigEntry(
-            hosts=("github.com", "api.github.com", "raw.githubusercontent.com", "codeload.github.com"),
-            provider="github",
-            auth="bearer",
-            token_env=token_env,
-        )
-        monkeypatch.setattr(_mod, "_config_override", [entry])
+        from tests.auth_helpers import inject_github_config
+        inject_github_config(monkeypatch, token_env)
 
     def test_make_request_no_token_no_auth_header(self, temp_dir, monkeypatch):
         """Without a token, requests carry no Authorization header."""
@@ -2529,8 +2521,6 @@ def test_make_request_no_auth_when_no_config(self, temp_dir, monkeypatch):
         """No auth header when no auth.json config exists."""
         monkeypatch.delenv("GITHUB_TOKEN", raising=False)
         monkeypatch.delenv("GH_TOKEN", raising=False)
-        import specify_cli.authentication.http as _mod
-        monkeypatch.setattr(_mod, "_config_override", [])
         catalog = self._make_catalog(temp_dir)
         req = catalog._make_request("https://github.com/org/repo/releases/download/v1/ext.zip")
         assert "Authorization" not in req.headers

tests/test_presets.py

@@ -1224,16 +1224,8 @@ class TestPresetCatalog:
     """Test template catalog functionality."""
 
     def _inject_github_config(self, monkeypatch, token_env="GH_TOKEN"):
-        """Inject a GitHub auth.json config entry for testing."""
-        from specify_cli.authentication.config import AuthConfigEntry
-        import specify_cli.authentication.http as _mod
-        entry = AuthConfigEntry(
-            hosts=("github.com", "api.github.com", "raw.githubusercontent.com", "codeload.github.com"),
-            provider="github",
-            auth="bearer",
-            token_env=token_env,
-        )
-        monkeypatch.setattr(_mod, "_config_override", [entry])
+        from tests.auth_helpers import inject_github_config
+        inject_github_config(monkeypatch, token_env)
 
     def test_default_catalog_url(self, project_dir):
         """Test default catalog URL."""
@@ -1481,8 +1473,6 @@ def test_make_request_no_auth_when_no_config(self, project_dir, monkeypatch):
         """No auth header when no auth.json config exists."""
         monkeypatch.delenv("GITHUB_TOKEN", raising=False)
         monkeypatch.delenv("GH_TOKEN", raising=False)
-        import specify_cli.authentication.http as _mod
-        monkeypatch.setattr(_mod, "_config_override", [])
         catalog = PresetCatalog(project_dir)
         req = catalog._make_request("https://github.com/org/repo/releases/download/v1/pack.zip")
         assert "Authorization" not in req.headers

tests/test_upgrade.py

@@ -24,13 +24,6 @@
     app,
 )
 
-
-@pytest.fixture(autouse=True)
-def _isolate_auth_config(monkeypatch):
-    """Ensure tests never read the real ~/.specify/auth.json."""
-    from specify_cli.authentication import http as _mod
-    monkeypatch.setattr(_mod, "_config_override", [])
-
 from tests.conftest import strip_ansi
 
 runner = CliRunner()
@@ -310,16 +303,8 @@ def _side_effect(req, timeout=None):
 
 
 def _inject_github_config(monkeypatch, token_env="GH_TOKEN"):
-    """Inject a GitHub auth.json config entry for testing."""
-    from specify_cli.authentication.config import AuthConfigEntry
-    import specify_cli.authentication.http as _mod
-    entry = AuthConfigEntry(
-        hosts=("github.com", "api.github.com", "raw.githubusercontent.com", "codeload.github.com"),
-        provider="github",
-        auth="bearer",
-        token_env=token_env,
-    )
-    monkeypatch.setattr(_mod, "_config_override", [entry])
+    from tests.auth_helpers import inject_github_config
+    inject_github_config(monkeypatch, token_env)
 
 
 class TestUserStory3:
@@ -350,8 +335,6 @@ def test_github_token_used_when_gh_token_unset(self, monkeypatch):
     def test_no_authorization_header_when_both_unset(self, monkeypatch):
         monkeypatch.delenv("GH_TOKEN", raising=False)
         monkeypatch.delenv("GITHUB_TOKEN", raising=False)
-        import specify_cli.authentication.http as _mod
-        monkeypatch.setattr(_mod, "_config_override", [])
         captured, side_effect = _capture_request_via_urlopen()
         with patch("specify_cli.authentication.http.urllib.request.urlopen", side_effect=side_effect):
             _fetch_latest_release_tag()
@@ -396,8 +379,6 @@ def test_gh_token_never_appears_in_failure_output(
     ):
         monkeypatch.setenv("GH_TOKEN", SENTINEL_GH_TOKEN)
         monkeypatch.delenv("GITHUB_TOKEN", raising=False)
-        import specify_cli.authentication.http as _mod
-        monkeypatch.setattr(_mod, "_config_override", [])
         with patch("specify_cli._get_installed_version", return_value="0.7.4"), patch(
             "specify_cli.authentication.http.urllib.request.urlopen", side_effect=side_effect
         ):
@@ -411,8 +392,6 @@ def test_github_token_never_appears_in_failure_output(
     ):
         monkeypatch.delenv("GH_TOKEN", raising=False)
         monkeypatch.setenv("GITHUB_TOKEN", SENTINEL_GITHUB_TOKEN)
-        import specify_cli.authentication.http as _mod
-        monkeypatch.setattr(_mod, "_config_override", [])
         with patch("specify_cli._get_installed_version", return_value="0.7.4"), patch(
             "specify_cli.authentication.http.urllib.request.urlopen", side_effect=side_effect
         ):