fix: address third Copilot review

Author: Adr1an04

src/specify_cli/integrations/catalog.py

@@ -436,10 +436,13 @@ def get_catalog_configs(self) -> List[Dict[str, Any]]:
     def add_catalog(self, url: str, name: Optional[str] = None) -> None:
         """Add a catalog source to the project-level config file.
 
-        The URL is validated before being written. Duplicate URLs are rejected.
-        Priority is derived as ``max(existing) + 1`` so the new entry sorts last
-        in the resolution order unless the user edits the file manually.
+        The URL is normalized (whitespace stripped) and validated before being
+        written. Duplicate URLs are rejected, including near-duplicates that
+        differ only by surrounding whitespace. Priority is derived as
+        ``max(existing) + 1`` so the new entry sorts last in the resolution
+        order unless the user edits the file manually.
         """
+        url = url.strip()
         self._validate_catalog_url(url)
         config_path = self.project_root / ".specify" / self.CONFIG_FILENAME
 
@@ -581,7 +584,12 @@ def remove_catalog(self, index: int) -> str:
             # Deleting the file lets the project fall back to built-in
             # defaults, which matches the behavior before any
             # `catalog add` was ever run.
-            config_path.unlink()
+            try:
+                config_path.unlink()
+            except OSError as exc:
+                raise IntegrationValidationError(
+                    f"Failed to delete catalog config {config_path}: {exc}"
+                ) from exc
 
         if isinstance(removed, dict):
             return removed.get("name", f"catalog-{index + 1}")

tests/integrations/test_integration_catalog.py

@@ -881,6 +881,42 @@ def test_add_catalog_defaults_missing_priority_to_index_plus_one(
         # max(implicit [1, 2]) + 1 == 3
         assert new_entry["priority"] == 3
 
+    def test_add_catalog_strips_whitespace_in_url(self, tmp_path, monkeypatch):
+        """Whitespace around the incoming URL should be normalized before write."""
+        self._isolate(tmp_path, monkeypatch)
+        cat = IntegrationCatalog(tmp_path)
+        cat.add_catalog("  https://a.example.com/catalog.json\n", name="a")
+
+        cfg_path = tmp_path / ".specify" / "integration-catalogs.yml"
+        data = yaml.safe_load(cfg_path.read_text(encoding="utf-8"))
+        assert data["catalogs"][0]["url"] == "https://a.example.com/catalog.json"
+
+    def test_add_catalog_rejects_whitespace_only_duplicate(self, tmp_path, monkeypatch):
+        """A second add with only whitespace differences must be rejected as a duplicate."""
+        self._isolate(tmp_path, monkeypatch)
+        cat = IntegrationCatalog(tmp_path)
+        cat.add_catalog("https://a.example.com/catalog.json", name="a")
+        with pytest.raises(IntegrationValidationError, match="already configured"):
+            cat.add_catalog("  https://a.example.com/catalog.json  ")
+
+    def test_remove_catalog_wraps_unlink_oserror(self, tmp_path, monkeypatch):
+        """An OSError from `Path.unlink` surfaces as IntegrationValidationError."""
+        self._isolate(tmp_path, monkeypatch)
+        cat = IntegrationCatalog(tmp_path)
+        cat.add_catalog("https://only.example.com/catalog.json", name="only")
+
+        from pathlib import Path as _Path
+
+        def boom(self, *args, **kwargs):
+            raise OSError("simulated unlink failure")
+
+        monkeypatch.setattr(_Path, "unlink", boom)
+
+        with pytest.raises(
+            IntegrationValidationError, match="Failed to delete catalog config"
+        ):
+            cat.remove_catalog(0)
+
     def test_remove_catalog_empty_list_gives_clear_error(self, tmp_path, monkeypatch):
         """Hand-edited empty `catalogs:` produces a clear error, not '0--1'."""
         self._isolate(tmp_path, monkeypatch)