fix(extensions): raise ValidationError for non-dict hook entries; fix wording

Raise ValidationError instead of silently skipping hook entries that
are not mappings. The silent skip allowed malformed manifests to pass
validation and crash later in HookExecutor.register_hooks() with an
AttributeError. Added test_hook_entry_non_dict_value_raises.

Change 'from AI agent' to 'across AI agents' in the extension remove
confirmation message — cmd_count is summed across all registered agents,
so the singular 'agent' was misleading. Updated CLI tests accordingly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: iamaeroplane

src/specify_cli/__init__.py

@@ -3140,7 +3140,7 @@ def extension_remove(
     if not force:
         console.print("\n[yellow]⚠  This will remove:[/yellow]")
         cmd_label = "command" if cmd_count == 1 else "commands"
-        console.print(f"   • {cmd_count} {cmd_label} from AI agent")
+        console.print(f"   • {cmd_count} {cmd_label} across AI agents")
         if skill_count:
             console.print(f"   • {skill_count} agent skill(s)")
         console.print(f"   • Extension directory: .specify/extensions/{extension_id}/")

src/specify_cli/extensions.py

@@ -299,7 +299,9 @@ def _validate(self):
             )
         for hook_name, hook_data in hooks.items():
             if not isinstance(hook_data, dict):
-                continue
+                raise ValidationError(
+                    f"'hooks.{hook_name}' must be a mapping, got {type(hook_data).__name__}"
+                )
             command_ref = hook_data.get("command")
             if not isinstance(command_ref, str):
                 continue

tests/test_extensions.py

@@ -448,6 +448,21 @@ def test_hook_non_dict_value_raises(self, temp_dir, valid_manifest_data):
         with pytest.raises(ValidationError, match="'hooks' must be a mapping"):
             ExtensionManifest(manifest_path)
 
+    def test_hook_entry_non_dict_value_raises(self, temp_dir, valid_manifest_data):
+        """A hook entry that is not a mapping raises ValidationError instead of silently skipping."""
+        import yaml
+
+        # hooks.after_tasks is a list instead of a dict — should fail validation,
+        # not silently pass and crash later in HookExecutor.
+        valid_manifest_data["hooks"]["after_tasks"] = ["x", "y"]
+
+        manifest_path = temp_dir / "extension.yml"
+        with open(manifest_path, "w") as f:
+            yaml.dump(valid_manifest_data, f)
+
+        with pytest.raises(ValidationError, match="'hooks.after_tasks' must be a mapping"):
+            ExtensionManifest(manifest_path)
+
     def test_valid_command_name_has_no_warnings(self, temp_dir, valid_manifest_data):
         """Test that a correctly-named command produces no warnings."""
         import yaml
@@ -3185,8 +3200,8 @@ def test_remove_confirmation_counts_primary_command_only(self, extension_dir, pr
             result = runner.invoke(app, ["extension", "remove", "test-ext"], input="n\n")
 
         plain = strip_ansi(result.output)
-        # The fixture has 1 command and 0 aliases → "1 command from AI agent"
-        assert "1 command from AI agent" in plain
+        # The fixture has 1 command and 0 aliases → "1 command across AI agents"
+        assert "1 command across AI agents" in plain
 
     def test_remove_confirmation_counts_aliases(self, temp_dir, project_dir):
         """Removal confirmation shows primary + alias count, not just primary."""
@@ -3239,9 +3254,9 @@ def test_remove_confirmation_counts_aliases(self, temp_dir, project_dir):
             result = runner.invoke(app, ["extension", "remove", "ext-with-alias"], input="n\n")
 
         plain = strip_ansi(result.output)
-        # 1 primary + 1 alias = "2 commands from AI agent" (not "1 command")
-        assert "2 commands from AI agent" in plain
-        assert "1 command from AI agent" not in plain
+        # 1 primary + 1 alias = "2 commands across AI agents" (not "1 command")
+        assert "2 commands across AI agents" in plain
+        assert "1 command across AI agents" not in plain
 
 
 class TestExtensionUpdateCLI: