fix: address PR review feedback

- Add type guard before 'in' check for effect to prevent TypeError on
  unhashable YAML values (list/dict)
- Comment out category/effect in template so authors must opt in
- Use VALID_EFFECTS constant in test instead of hard-coded values

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: mnriem

extensions/template/extension.yml

@@ -15,11 +15,11 @@ extension:
 
   # CUSTOMIZE: Extension category — describes what the extension operates on
   # Common values: docs, code, process, integration, visibility
-  category: "process"
+  # category: "process"
 
   # CUSTOMIZE: Extension effect — whether it modifies project files
   # One of: read-only | read-write
-  effect: "read-write"
+  # effect: "read-write"
 
   # CUSTOMIZE: Your name or organization name
   author: "Your Name"

src/specify_cli/extensions.py

@@ -212,9 +212,9 @@ def _validate(self):
 
         # Validate optional effect field
         if "effect" in ext:
-            if ext["effect"] not in VALID_EFFECTS:
+            if not isinstance(ext["effect"], str) or ext["effect"] not in VALID_EFFECTS:
                 raise ValidationError(
-                    f"Invalid extension.effect '{ext['effect']}': "
+                    f"Invalid extension.effect '{ext.get('effect')}': "
                     f"must be one of {sorted(VALID_EFFECTS)}"
                 )
 

tests/test_extensions.py

@@ -317,7 +317,7 @@ def test_valid_effect(self, temp_dir, valid_manifest_data):
         """Test manifest with valid effect values."""
         import yaml
 
-        for effect in ("read-only", "read-write"):
+        for effect in sorted(VALID_EFFECTS):
             valid_manifest_data["extension"]["effect"] = effect
             manifest_path = temp_dir / "extension.yml"
             with open(manifest_path, 'w') as f: