Skip to content

Commit f65bf6c

Browse files
committed
fix: remove unused short_name parameter from branch numbering functions
The check_existing_branches (bash) and Get-NextBranchNumber (PowerShell) functions no longer use the short_name parameter since they now find the global maximum across ALL features. This commit: 1. Removes the unused parameter from function signatures 2. Updates all call sites to not pass the parameter This prevents the scripts from failing when the function is called with the wrong number of arguments.
1 parent a0ca101 commit f65bf6c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

scripts/bash/create-new-feature.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ fi
238238
if [ -z "$BRANCH_NUMBER" ]; then
239239
if [ "$HAS_GIT" = true ]; then
240240
# Check existing branches on remotes
241-
BRANCH_NUMBER=$(check_existing_branches "$BRANCH_SUFFIX" "$SPECS_DIR")
241+
BRANCH_NUMBER=$(check_existing_branches "$SPECS_DIR")
242242
else
243243
# Fall back to local directory check
244244
HIGHEST=$(get_highest_from_specs "$SPECS_DIR")

scripts/powershell/create-new-feature.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ if ($ShortName) {
210210
if ($Number -eq 0) {
211211
if ($hasGit) {
212212
# Check existing branches on remotes
213-
$Number = Get-NextBranchNumber -ShortName $branchSuffix -SpecsDir $specsDir
213+
$Number = Get-NextBranchNumber -SpecsDir $specsDir
214214
} else {
215215
# Fall back to local directory check
216216
$Number = (Get-HighestNumberFromSpecs -SpecsDir $specsDir) + 1

0 commit comments

Comments
 (0)