fix: refresh speckit_version in init-options on integration update#2647
Open
PascalThuet wants to merge 1 commit into
Open
fix: refresh speckit_version in init-options on integration update#2647PascalThuet wants to merge 1 commit into
PascalThuet wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds tracking of the current speckit_version in .specify/init-options.json and ensures integration upgrade refreshes it.
Changes:
- Persist
speckit_versionwhen updating integration init options. - Add an integration test verifying
integration upgrade --forceupdatesspeckit_version.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/integrations/test_integration_subcommand.py | Adds test coverage to ensure speckit_version is refreshed during upgrade. |
| src/specify_cli/init.py | Writes the current speckit_version into init options during integration option updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c300d70 to
fa2b5da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.specify/init-options.jsonspeckit_versionwhenever active integration metadata is updated.Why
init-options.jsonstores active integration metadata such asintegration,ai,context_file,script, andai_skills, butspeckit_versionstayed pinned to the version that originally initialized the project.After upgrading Spec Kit, that made
init-options.jsondiverge from.specify/integration.jsonand the integration manifests, which already record the current Spec Kit version.For multi-agent projects, non-default integration installs/upgrades also update
.specify/integration.json, so this keeps the global init-options version aligned while preserving the activeai,integration, andcontext_filevalues.If the intended meaning of this field is historical instead, it should probably be renamed or documented separately, for example as
initialized_speckit_version.Validation
uv run pytest tests/integrations/test_integration_subcommand.py -v